search

NuKeeperDotNet / NuKeeper

Automagically update nuget packages in .NET projects
Apache License 2.0
541 stars 127 forks source link

feat: Support custom templates for commits + PRs #1048

Open CrispyDrone opened 4 years ago

CrispyDrone commented 4 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature.

:arrow_heading_down: What is the current behavior?

All commit messages, and pull request title and body templates are hardcoded.

:new: What is the new behavior (if this is a feature change)?

This commit introduces mustache templates for commit messages, and pull request titles and bodies.

The design consists of templates with predefined properties. A custom template can be provided.

Stubble has been chosen as the template renderer.

It is possible to define additional context for the templates, this also includes delegates. These can be provided as the value of a "_delegates" key in the context.

:boom: Does this PR introduce a breaking change?

No.

:bug: Recommendations for testing

Creation of pull requests and commits.

:memo: Links to relevant issues/docs

N/A

:thinking: Checklist before submitting

clooudch commented 4 years ago

will this feature be merged?

csMACnz commented 3 years ago

I am very interested in the ability to set custom templates for commit messages and PR titles. We have a requirement to put a JIRA ticket number in both of these places.

caffeineinc commented 3 years ago

I'm also interested in this; seems like a relatively small change too!

CrispyDrone commented 3 years ago

Rebased to incorporate new changes on master and fix conflicts.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

csMACnz commented 3 years ago

Heya, what needs done to get this functionality added? This still remains a dealbreaker of using this tool for us.

msallin commented 3 years ago

We are very interested in having custom commit messages, as we are using conventional commits to automatically set our version.

We are able to invest time into this feature. How to go on with this PR? What's missing? How can we help?

msallin commented 3 years ago

Any news? Still ready to help, if necessary.

cc org members: @slang25 @shep1987 @MarcBruins @AnthonySteele

msallin commented 3 years ago

For those which are looking for the corresponding issue (closed because of inactivity): https://github.com/NuKeeperDotNet/NuKeeper/issues/897

msallin commented 3 years ago

@CrispyDrone can you please rebase the branch on the latest master?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.