search

NuKeeperDotNet / NuKeeper

Automagically update nuget packages in .NET projects
Apache License 2.0
540 stars 128 forks source link

Use targetBranch when running in a Azure DevOps Pipeline #1103

Closed MartinDemberger closed 2 years ago

MartinDemberger commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Fixes Bug #1102

:arrow_heading_down: What is the current behavior?

Currently the targetBranch parameter isn't used when running in a Azure DevOps Pipeline.

:new: What is the new behavior (if this is a feature change)?

Now the parameter is used.

:boom: Does this PR introduce a breaking change?

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

MartinDemberger commented 3 years ago

In CreateSettingsFromRemote the targetBranch isn't used. Is this correct?

kwlin commented 3 years ago

Isn't this the same fix as #1078 ?

MartinDemberger commented 3 years ago

Isn't this the same fix as #1078 ?

No it isn't. In #1078 is the targetbranch for CreateSettingsFromRemote and in this one for CreateSettingsFromLocal which is used in my Azure Build Pipeline.

thijsk commented 3 years ago

Just ran into this issue, is there anyone still working on this?

MartinDemberger commented 3 years ago

I'm not sure if NuKeeper is still alive. I have created my own version in my private repository with the needed changes.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

msallin commented 2 years ago

@MartinDemberger can you please rebase the branch on the latest master. Ty!

MartinDemberger commented 2 years ago

@MartinDemberger can you please rebase the branch on the latest master. Ty!

@msallin @I did the rebase but am unsure if it's done correct. There are changes in the changeset which I don't know.

You can give me a short hint if I have done an error. Then I will redo the changes on a clean branch.

skolima commented 2 years ago

@MartinDemberger I'm afraid something went wrong with the rebase - your changes were quite clean 3-4 lines, and this has about 30 extra commits. Could you re-do this so that the PR diff only shows your changes?

MartinDemberger commented 2 years ago

I have recreated this PR as #1139 1139