search

NuKeeperDotNet / NuKeeper

Automagically update nuget packages in .NET projects
Apache License 2.0
540 stars 128 forks source link

FailOnGitError added #1104

Closed MartinDemberger closed 2 years ago

MartinDemberger commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

A new option is added. When the option FailOnGitError is set the run failes when the call to get the available versions failes.

This is only the first part of a fix for #930

:arrow_heading_down: What is the current behavior?

On most of git calls the error is ignored and NuKeeper notifies success.

:new: What is the new behavior (if this is a feature change)?

A new option --failongiterror is introduced and when this option is set an error in a git call results in an error of NuKeeper.

In the current process the option is only used when searching for the available package versions.

:boom: Does this PR introduce a breaking change?

No, the default behaviour is unchanged.

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

msallin commented 2 years ago

@MartinDemberger can you please rebase the branch on the latest master? Ty!

MartinDemberger commented 2 years ago

@MartinDemberger can you please rebase the branch on the latest master? Ty!

@msallin @I did the rebase but am unsure if it's done correct. There are changes in the changeset which I don't know.

You can give me a short hint if I have done an error. Then I will redo the changes on a clean branch.

msallin commented 2 years ago

Doesn't look correct to me. I looked at your fork, to see if I can advise. The problem is that you did some merges and additionally, the commit on which this branch is based, is behind the master.

If you don't mind, I suggest that you reapply the changes on a clean branch. The simplest thing to do is probably:

  1. Ensure that the master in your fork is up to date
  2. Create a new branch on master
  3. Cherrypick your commit
  4. Create a new PR
MartinDemberger commented 2 years ago

I created #1140 with the cleaned changes.