NuKeeperDotNet / NuKeeper

Automagically update nuget packages in .NET projects
Apache License 2.0
540 stars 128 forks source link

Fix BitBucketLocal not respecting target branch parameter #1107

Closed arikalish closed 2 years ago

arikalish commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug Fix

:arrow_heading_down: What is the current behavior?

--targetBranch option does not work against locally hosted BitBucket repositories. PRs are pointed at default branch instead of specified branch.

:new: What is the new behavior (if this is a feature change)?

PRs to locally hosted BitBucket repositories point to the specified branch when --targetBranch is specified.

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

Pass --target-branch <branchname> to NuKeeper.

:memo: Links to relevant issues/docs

N/A

:thinking: Checklist before submitting

arikalish commented 3 years ago

Looks like there's something wrong with the build? I didn't change any tested areas in a way that would break them. Tests pass on my local machine.

Seeing other PRs fail for similar reasons.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

arikalish commented 3 years ago

Still relevant

skolima commented 2 years ago

Looks good. Thanks!