search

NuKeeperDotNet / NuKeeper

Automagically update nuget packages in .NET projects
Apache License 2.0
542 stars 126 forks source link

NuKeeper is reverting my other changes in it's pull requests. #1112

Open MarkFl12 opened 3 years ago

MarkFl12 commented 3 years ago

🐛 Bug Report

I'm running it in TeamCity using a powershell command and quite a few times now it's put in a pull request with the package upgraded but a selection of other recent changes reverted out.

I'm using the command: nukeeper repo https://company.visualstudio.com/CompanyName/_git/ProjectName %GitAccessToken% --maxpackageupdates 500 --exclude "^(AWSSDK|Microsoft|Hangfire|Amazon)\." --age=0 --verbosity detailed --checkout-directory C:\nk\%build.number%all\

Expected behavior

That it upgrades my packages and doesn't undo other work.

Reproduction steps

I can't see anything different about when it does this compared to when it doesn't even with --verbosity detailed. Cancelling the PR and deleting the branch followed by re-running will usually not cause the issue again.

Configuration

Version: 0.34.0

Platform if applicable:

msallin commented 3 years ago

Can you provide a repro?

MarkFl12 commented 3 years ago

That makes it happen every time? I'm not sure, I could try running it until the issue happens to get some logs?

msallin commented 3 years ago

It does not happen every time? Could it be that the branch you are creating the PR from is behind?

MarkFl12 commented 3 years ago

It might well be that the branch is behind, however the checkout directory doesn't even exist until NuKeeper creates it so if this is the case, it's NuKeeper itself that's pulling already behind.

msallin commented 3 years ago

Do you have the chance to check the directory which was pulled by NuKeeper after the problem happened? I.e. check the commit hash and verify that the correct state was pulled.

MarkFl12 commented 3 years ago

I might well be able to, leave it with me.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.