NuKeeperDotNet / NuKeeper

Automagically update nuget packages in .NET projects
Apache License 2.0
540 stars 129 forks source link

Add nuget restore CLI PackagesDirectory for package.config #1113

Closed Jamie-Clayton closed 2 years ago

Jamie-Clayton commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix for nuget restore CLI.

:arrow_heading_down: What is the current behavior?

Nukeeper fails to restore nuget packages for older project types with package.config entries.

:new: What is the new behavior (if this is a feature change)?

Includes the missing nuget CLI option required for the restoring of packages.

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

Tested against 24 Azure DevOps private repositories with multiple private NuGet sources.

:memo: Links to relevant issues/docs

See - https://docs.microsoft.com/en-us/nuget/reference/cli-reference/cli-ref-restore. The resent nuget versions include the required option "-PackagesDirectory" when restoring via package.config files.

:thinking: Checklist before submitting

Jamie-Clayton commented 3 years ago

@AnthonySteele @MarcBruins @shep1987. Would you mind reviewing the following PR. I'm working through a series of legacy .net software solutions to sanity check the changes before creating the PR and working through the MAC, Linux AzDO pipeline you have configured.

Jamie-Clayton commented 3 years ago

Bump - Let's get this into main?

skolima commented 2 years ago

Thanks for your contribution, and for fixing my old wonky test with hardcoded credentials 😅