NuKeeperDotNet / NuKeeper

Automagically update nuget packages in .NET projects
Apache License 2.0
540 stars 129 forks source link

Bump version in Dockerfile to 0.35.0 #1141

Closed skolima closed 2 years ago

skolima commented 2 years ago

Update to current release in the Dockerfiles provided.

msallin commented 2 years ago

Is this necessary, can't we just use the latest?

skolima commented 2 years ago

Problem with having latest in there is that the Docker images aren't deterministic then.

And building them becomes problematic, as it's either "invalidate every time and build from scratch" or "we'll get whatever is cached on the build machine, perhaps the current version, perhaps 3 versions stale".

msallin commented 2 years ago

I see. How do we release a new NuKeeper version? Maybe we can automate this (i.e. create the PR after we released a version) I'm working on getting a bit of dev power from our organization, to do such things.

skolima commented 2 years ago

There's a (somewhat grotty) Azure Devops pipeline. It's not the most readable, TBH. I'd prefer GitHub actions, or really anything that's versioned in the repository as a text file. The Docker images used to be released automatically by Docker Hub - but now they've changed their licensing, there's no longer a free build tier for Open Source - so the last ones was built on my machine. That could also move to GitHub Actions - there's free automation here for it.