search

NuSTAR / nustar-clock-utils

Utilities for a precise timing calibration of NuSTAR data
3 stars 3 forks source link

Update dependencies to latest versions #46

Closed matteobachetti closed 3 years ago

matteobachetti commented 3 years ago

This should solve #42, and something more. It would be useful to test it in a safe environment to avoid regressions

bwgref commented 3 years ago

Just installed into a clean python 3.9 environment and things seemed to work fine.

One general comment (maybe this should be obvious?) is that the pip install requirements works fine, but if you do the same thing under conda there are several things that have different names (scikit-learn vs sklearn, for example) and some things don't seem to want to install.

I guess this is normal (and the installation instructions say to use pip).

Otherwise both the dash interface and standard clock creation seem to work fine.

I think you're fine to merge this in.

matteobachetti commented 3 years ago

Ok, merging. I actually wasn't aware of (/did not remember about) the different naming and incompatibilities for conda packages :O