NuSTAR / nustar_pysolar

Python scripts for NuSTAR Solar analysis
MIT License
7 stars 6 forks source link

use_2to3 in setup.py invalid? #64

Closed ianan closed 1 year ago

ianan commented 2 years ago

Installing on a fresh anaconda(python 3.9.7)/sunpy setup I was getting the error error in nustar_pysolar setup command: use_2to3 is invalid. after running python setup.py install.

Deleting line 117 in setup.py use_2to3=True, fixed the issue and could install no problem.

bwgref commented 2 years ago

I haven't tested with python 3.9 yet...nor have I tested with astropy v4 (I think?). My setup.py for this is probably four years old, so it's probably way out of date.

ianan commented 2 years ago

I think it was actually with astropy v5... but a simple fix if others encounter the same issue on newer installs.

bwgref commented 1 year ago

Side note, at some point this whole package needs to be updated to the Astropy APE 17 installation without the use of astropy-helpers. I did this for nustar-gen-utils, but I never got around to it for nustar_pysolar.

bwgref commented 1 year ago

Should be deprecated now with #71