search

NuSkooler / enigma-bbs

ENiGMA½ BBS Software
https://nuskooler.github.io/enigma-bbs/
BSD 2-Clause "Simplified" License
549 stars 105 forks source link

Bottom bar one space short #161

Open SemperFu opened 6 years ago

SemperFu commented 6 years ago

Sorry for all the issues, just putting them in as I see them.

I've noticed the welcome screens and some of the bars seem off at the bottom. After making a test background I can confirm its to the left one space.

Expected behavior Display Normally Actual behavior You can see the 2 orange bars are misaligned. https://imgur.com/a/RgZbT

NuSkooler commented 6 years ago

@Jasin2069 There are definitely bugs. Keep 'em commin'!

I'm not sure what you're saying exactly here. Can you attach something I can use to reproduce this with?

SemperFu commented 6 years ago

I have a link to imgur with a visual under Actual behavior

https://imgur.com/a/RgZbT

The top one is an ansi are with a border and 2 orange bars at the bottom to show where they align. The second picture show that the bottom line is off 1 space to the left.

NuSkooler commented 6 years ago

Yeah I'm not sure what I'm looking at here

On Wed, Mar 14, 2018, 10:25 PM Jasin2069 notifications@github.com wrote:

I have a link to imgur with a visual under actual

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NuSkooler/enigma-bbs/issues/161#issuecomment-373256891, or mute the thread https://github.com/notifications/unsubscribe-auth/ABcH26eroHBfTHNtvsyC9kae4EbRlaF6ks5tee0ogaJpZM4SriDK .

SemperFu commented 6 years ago

@NuSkooler There are 2 pictures in the album. One is a screenshot of The actual bbslist.ans. Look at the very bottom line. I added 2 orange bars, one on the left and one on the right to show it's alignment with the side bars.

The other image is a screenshot from being logged in and going to bbslist. Look at the orange bars now, they do not line up. The last char is also black. The whole bottom line is shifted one to the left.

I can try and edit the images and circle what I'm talking about.

SemperFu commented 6 years ago

Here is a cropped picture that should help

https://imgur.com/mpnY79y

SemperFu commented 6 years ago

Ok, this took a bit because not every screen was doing it. I figured out the block causing it. If you have a block in 80,24 the 25th line will be shifted to the left one. If 80,24 is blank then line 25 will display correctly. Here is two more screenshots. One with it blank and one filled in.

Image 1 - Everything filled in -Line 25 shifted to the left Image 2 - One block removed - Background shifted up 1 Image 3 - Two blocks removed - Displays fine I added line numbers to make it a little easier

https://imgur.com/a/rH9Du

NuSkooler commented 6 years ago

What terminal(s) have you tested this in?

SemperFu commented 6 years ago

@NuSkooler Both netrunner and syncterm

SemperFu commented 6 years ago

@NuSkooler I can test others. What's your recommended client? I like netrunner but it doesn't support ssh anyways.

NuSkooler commented 6 years ago

NetRunner, SyncTERM, EtherTerm, VTX, and fTelnet are all popular and work well. Just making sure this wasn't some oddball case. I should have some time to start looking into this in the upcoming week.

SemperFu commented 6 years ago

Not a problem. I'd love to help look for this issue but I'm new to javascript. I know C# but if I start to understand it more I may help in the future as I find my way around it.

NuSkooler commented 6 years ago

So far I've only been able to reproduce this in NetRunner. SyncTERM seems to show the correct layout (if you place a block @ 80,25 it will wrap). Will do some more testing...

EDIT: VTX works 100% properly from my testing (no shift, draws all the way to 80,25) EDIT2: EtherTerm works 100% properly (same as VTX above).

So far for me anyway, the only bug seems to be around NetRunner. Will need a better suite of tests to see if it's a NR bug or ENiG. Can you confirm any of the above?

SemperFu commented 6 years ago

Let me install the others. I'll have to build a webserver for VTX so prob won't get to that until later this week but will do etherterm now.

SemperFu commented 6 years ago

So you're right, looks like etherterm is the best at this. I'll prob be switching to that since it does ssh as well.

80x24 and 80x25 filled in Netrunner - Wraps up a line and shifts syncterm - Wraps up a line etherterm - Displays fine

80x24 removed 80x25 filled in Netrunner - Wraps up a line Syncterm - Wraps up a line etherterm - Displays fine

80x25 Removed 80x24 filled in Netrunner Bottom line shifts 1 to the left syncterm - Displays fine etherterm - Displays fine

80x24 and 80x25 removed Netrunner - Displays fine Syncterm - Displays fine Etherterm - Displays fine

NuSkooler commented 6 years ago

@codewar65 happen to have any insight on this?

NuSkooler commented 6 years ago

Similar issue for ref: https://pasteboard.co/HiFBtWt.png

NuSkooler commented 6 years ago

https://snag.gy/61eZzA.jpg

IBBBS commented 3 years ago

I've been plagued with this during the development of Westwood. The workaround seems to be in the management of the ANS file screen size (say modify to 23 instead of 24 or 25) and sometimes it will get the cursor to align with the MCI prompt areas. That being said, when testing execution, the adjustment will appear corrected with one terminal (like Netrunner) and not another (like Syncterm). I've also observed this on Xibalba which tells me I'm not the cause of the issue LOL. Screenshot_20210408_100955

Term settings on both Netrunner and Syncterm are at 80x25.

Here's another example. ANS form canvas size is 25 (so when "smash your keyboard" prompt comes up, you are using 26 lines. Important to note, line 25 of ANS is blank... if you look at this snapshot, smash keyboard prompt is showing up on line 25! I'm not sure if this is related but watch what happens when I change canvas size to 24....

So here is canvas at 25: westwood_cursor1

Now removing line 25 of canvas (which was blank to begin with - just setting overall canvas to 24): westwood2

My text is aligned, but now smash your keyboard prompt is intruding in my art on line 24.

I did go one step further (setting canvas to 23) and that didn't help. Text alignment maintained (which conflicts with one of my notes above) and smash prompt continues to creep up. westwoodcursor3

NuSkooler commented 2 years ago

This has started to get looked at more with #222 resolved. Can any of you try with the latest code?

See also this spreadsheet tracking some of the issues

NuSkooler commented 1 year ago

@WestwoodBBS @SemperFu or @cognitivegears anyone know if this is still an issue?

cognitivegears commented 1 year ago

I'm not positive but I'm doing a bunch of terminal testing right now and still seeing some weirdness (though I haven't seen this issue specifically) - I'd recommend keeping this open for now, I hope to have more soon. And if someone can catch this again in the meantime, please throw a screen on pastebin or base64'd here or something to test with.

IBBBS commented 1 year ago

@WestwoodBBS @SemperFu or @cognitivegears anyone know if this is still an issue?

I will have to take a look-see. I haven't done any artwork mods in sometime. I will try to look this weekend

cognitivegears commented 1 year ago

Ok I've checked in a few more fixes that could fix these, including incompatibilities with PabloDraw, changing the default art and layout to all be 24 lines, along with other previous changes. I've tested with a bunch of terminals and haven't been able to find any more issues. There is one open issue to address some unhandled ansi codes, but those probably would not effect the described issues here. @WestwoodBBS and others please pull the latest and let us know if you still see any issues. Thanks!

IBBBS commented 1 year ago

Will do

On Wed, Sep 6, 2023, at 9:27 AM, Nathan Byrd wrote:

Ok I've checked in a few more fixes that could fix these, including incompatibilities with PabloDraw, changing the default art and layout to all be 24 lines, along with other previous changes. I've tested with a bunch of terminals and haven't been able to find any more issues. There is one open issue to address some unhandled ansi codes, but those probably would not effect the described issues here. @WestwoodBBS https://github.com/WestwoodBBS and others please pull the latest and let us know if you still see any issues. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/NuSkooler/enigma-bbs/issues/161#issuecomment-1708363208, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASUPVMZ24CWLATJWQZECWJTXZB25NANCNFSM4EVOEDFA. You are receiving this because you were mentioned.Message ID: @.***>

Sysop - Westwood BBS King George, VA

cognitivegears commented 1 year ago

To clarify, I'm not aware of issues other than #414, an issue with Netrunner. I'm trying to chase that one down still.

NuSkooler commented 1 year ago

@cognitivegears Sounds like this one can probably be closed, perhaps pending @WestwoodBBS feedback?

IBBBS commented 1 year ago

I think you nailed the bug. I updated on Westwood and checked it out, and also checked out Xibalba. All looks great. ~-Nuke-~

On Wed, Sep 6, 2023, at 3:04 PM, Bryan Ashby wrote:

@cognitivegears https://github.com/cognitivegears Sounds like this one can probably be closed, perhaps pending @WestwoodBBS https://github.com/WestwoodBBS feedback?

— Reply to this email directly, view it on GitHub https://github.com/NuSkooler/enigma-bbs/issues/161#issuecomment-1708933512, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASUPVMYRSTQZB4XU7STZPNTXZDCKDANCNFSM4EVOEDFA. You are receiving this because you were mentioned.Message ID: @.***>

Sysop - Westwood BBS King George, VA

cognitivegears commented 1 year ago

Awesome, thanks for the confirmation @WestwoodBBS!!

NuSkooler commented 1 year ago

Awesome work!

IBBBS commented 1 year ago

Might have found one instance - on Xibalba - user information screen - using SyncTerm:

On Thu, Sep 7, 2023, at 8:56 PM, Nathan Byrd wrote:

Awesome, thanks for the confirmation @WestwoodBBS https://github.com/WestwoodBBS!!

— Reply to this email directly, view it on GitHub https://github.com/NuSkooler/enigma-bbs/issues/161#issuecomment-1710935579, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASUPVMZJWQBK57A7GN3AOQTXZJUK3ANCNFSM4EVOEDFA. You are receiving this because you were mentioned.Message ID: @.***>

Sysop - Westwood BBS King George, VA

cognitivegears commented 1 year ago

I reopened to take a look, thanks for the report. I do wonder though, I seem to remember that that screen may be one of them that I fixed from 25 to 24 rows, but I wonder if that's made it to Xibalba yet. I'll take a look as soon as I can and see what I can find out, thank again!