NuSkooler / enigma-bbs

ENiGMA½ BBS Software
https://nuskooler.github.io/enigma-bbs/
BSD 2-Clause "Simplified" License
545 stars 104 forks source link

Full screen ANSIs don't display properly since some point in 0.0.10-alpha #239

Closed davestephens closed 2 years ago

davestephens commented 5 years ago

Certain full screen ANSIs don't seem to display properly until some point in 0.0.10-alpha

Environment Using latest Docker image (fdce4c9)

Expected behavior image

Actual behavior image

Steps to reproduce Ignoring the fact that there are other issues with this ANSI, the line wrapping seems to be going wrong somewhere. Deleting the contents of the last column and resaving the ANSI seems to sort the issue.

The source ANSI is https://github.com/davestephens/bbs-ansi-adverts/blob/master/adverts/ds94.ans

NuSkooler commented 5 years ago

Any more info on this? I haven't seen this to be an issue anywhere. Can this be done with a more simplistic ANSI so it's easier to work with when debugging?

Related to #161?

davestephens commented 5 years ago

I can give you a few ansis that cause the issue if that helps? Trouble is I don't know what it is in the ANSI that causes the issue, so difficult for me to produce a test case!

NuSkooler commented 5 years ago

@davestephens The more the better probably unless you can isolate it. Might want to try what's in #161 and see if it's the same issue.

Get-Gud-Dev commented 4 years ago

I have a report to add to the pile...

In my case I'm having troubles making any of them work, me and my kid have both made big ansis that do not show up properly on either NR or Ether, VTX is perfect though! image

It seems like everything is like this. image

I have just been using a web ansi editor and some pablodraw and using the files they generate. I can get you the ANS files if they would help, but it seems almost all of the ones we've made have come out this way.

Here's a link to a repo I took just moments after putting up the report initially, my whole enigma directory and it is pretty much stock. https://gitlab.com/getten-gud/gg-bbs-backups/tree/master

the gg-theme's USERLOG and I wanna say general's WELCOME1 are the ones on display there

NuSkooler commented 4 years ago

I think the general work around is <= 79 columns (and <= 24 rows for non-scollers). I'll be re-visiting how art is handled and drawn in a future update, but even then I'm not sure this will be possible for all terminals which is why 79x24 has become such a thing in the BBS world.

Get-Gud-Dev commented 4 years ago

I think the general work around is <= 79 columns (and <= 24 rows for non-scollers). I'll be re-visiting how art is handled and drawn in a future update, but even then I'm not sure this will be possible for all terminals which is why 79x24 has become such a thing in the BBS world.

hells yes if all I have to do is keep to 79x24 to be safe, I'm cool with that!

NuSkooler commented 4 years ago

@GettenGud If that doesn't do the trick let me know and I'll bump up the priority of looking into this more. It's basically the rule I follow on Xibalba and seems to work for the terminals I test though.

davestephens commented 4 years ago

I don't think this is just a <79 columns issue - when I get some time I'll isolate specific examples but I found simply opening and resaving the affected ANSIs worked.

I noticed it with the ANSIs in my BBS adverts repo - some of them started rendering incorrectly once I flipped to 0.0.10.

On Wed, 4 Dec 2019, 03:59 GettenGud, notifications@github.com wrote:

After looking, it appears that the stock template files that come with the install are 80 cols, off by one, isn't that great? haha. As a new user I used them assuming it'd be good, so perhaps either fixing it up or creating a new screen-safe template would be worthwhile.

I'm still pretty new at all this, but I could probably cut them down one column without destroying them, I'm also making my own template so I could also make some more barebones ans files as I go.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NuSkooler/enigma-bbs/issues/239?email_source=notifications&email_token=AAFDGMG3WAMP4TXHE6KJDUDQW4TK3A5CNFSM4H6UIUF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3UXGY#issuecomment-561466267, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFDGMG5PV27Q7VARSUNDCDQW4TK3ANCNFSM4H6UIUFQ .

Get-Gud-Dev commented 4 years ago

Here's an image for a template I tried making 79, set against the proper backdrop. it doesn't do the same things that it did before but it is still behaving strangely, image

Something really weird I'm noticing here is that a bunch of my image is missing, where's all the light blue on line 2? it goes straight from the border to the shaded colors!

Get-Gud-Dev commented 4 years ago

Here's that particular file, pardon the ZIP github demanded it of me WELCOME1.zip

Get-Gud-Dev commented 4 years ago

My particular issue may be unrelated, sorry- I was able to fix my ANSI file by using Moebius instead of Pablo and the older version of the browser ANSI so I suspect that has been my problem. Hope that helps someone else though I'm having MUCH more consistent results.

It wasn't enough to load the file, I had to re-draw all characters that were being missed on the terminal. Black shaded blocks were a real problem too as sometimes they'd just be empty and the terminal would skip over them.

Here's a copy of the GOOD file, I know nothing about this format but I'd like to try and compare them and see if maybe there's a way of fixing files that otherwise appear fine but break like this. WELCOME1.zip

NuSkooler commented 4 years ago

@GettenGud Thanks. I'll try to remember to archive up the save vs re-saved version of your original WELCOME1.zip also. I'm not yet sure if there is anything we can do about it other than perhaps some sort of pre-processing of art files.

NuSkooler commented 4 years ago

I think there may be a mix of issues in here, but the bit about opening and re-saving makes me think at least some of them may have been fixed along with #244. Can someone verify?

NuSkooler commented 2 years ago

Assuming this is not working due to inactivity. Please re-open if this is not the case!