NuSkooler / enigma-bbs

ENiGMA½ BBS Software
https://nuskooler.github.io/enigma-bbs/
BSD 2-Clause "Simplified" License
537 stars 104 forks source link

Legacy file transfers often fail #448

Open NuSkooler opened 2 years ago

NuSkooler commented 2 years ago

At some point legacy (Z/Y/etc.) transfers -- especially those over SSH -- have become generally broken. ie: Up/Downloads result in errors, aborted, so on. Handling varies a bit by client.

Below is a current matrix needing more investigation.

Terminal Upload SEXYZ Upload rz Download SEXYZ Download sz
MagiTerm (Win) Telnet OK, SSH Magi crashes Telnet OK, SSH (NoUp) Telnet OK Telnet OK
NetRunner (Win) Telnet Fails (NoUp), SSH fails (NoUp) Telnet Fails (NoUp), SSH fails (NoUp) Telnet OK Telnet OK
SyncTERM (Linux) TODO TODO TODO TODO
SyncTERM (Win) TODO TODO TODO TODO

NoUp indicates no upload at all / complete failure -- generally "silent"

DaiTengu commented 2 years ago

Rob has mentioned there are issues with the 1.2 version of SyncTERM and uploads/downloads. the "release" version (1.1) is apparently OK.

NuSkooler commented 2 years ago

@DaiTengu Thanks for that info. I'll split out some of the relevant versions and put some details in the Terminal Testing sheet

stlalpha commented 1 year ago

At some point legacy (Z/Y/etc.) transfers -- especially those over SSH -- have become generally broken. ie: Up/Downloads result in errors, aborted, so on. Handling varies a bit by client.

Below is a current matrix needing more investigation.

Terminal Upload SEXYZ Upload rz Download SEXYZ Download sz MagiTerm (Win) Telnet OK, SSH Magi crashes Telnet OK, SSH (NoUp) Telnet OK Telnet OK NetRunner (Win) Telnet Fails (NoUp), SSH fails (NoUp) Telnet Fails (NoUp), SSH fails (NoUp) Telnet OK Telnet OK SyncTERM (Linux) TODO TODO TODO TODO SyncTERM (Win) TODO TODO TODO TODO NoUp indicates no upload at all / complete failure -- generally "silent"

Can add VTX sexyz ymodem xfers as failing as well:

Description: Uploads via websocket using VTX error consistently with:

{"name":"ENiGMA½ BBS","hostname":"c028590e9fb5","pid":17,"nodeId":1,"sessionId":"wAUX7reDnKp","username":"spaceman","level":40,"error":"External process error: Process exited with exit code 1","msg":"File transfer error","time":"2023-01-02T04:15:06.980Z","v":0}

To Reproduce Point VTX client to your wss proxy or endpoint, go to file transfers, choose upload, blind, y-modem, upload a zipfile

Expected Behavior File to transfer successfully, be processed by file upload processor, added to file bases and made available

Actual Behavior Upload silently fails (logged as noted above). Upload completes from client side, but enigma (sexy ymodem in this case) doesnt recognize the file xfer as complete, sexyzmodem doesnt exit upon client send finishing. Bbs will eventually return to the upload protocol selection screen. File is present in the uploaded /tmp directory. File is not imported to bbs.

Environment current docker container - running on ubuntu 22.04

stlalpha commented 1 year ago

ftelnet works mostly using wss - but you have to put sexyz ymodem into ymodem-g mode (-rg). If you do that- the file uploads and enigma just sits there after the client upload completes, but if you hit enter - it will process the file and upload it and make it available on the bbs.