NuSkooler / enigma-bbs

ENiGMA½ BBS Software
https://nuskooler.github.io/enigma-bbs/
BSD 2-Clause "Simplified" License
537 stars 104 forks source link

Investigate additional ANSI Escape sequences #496

Closed cognitivegears closed 11 months ago

cognitivegears commented 1 year ago

Is your feature request related to a problem? Please describe. This was related it issue #494. For that I added additional sequences, including t ,E, F, G, S, and T that are supported by PabloDraw. However, I just added the codes to prevent breakage, not implemented additional functionality.

Describe the solution you'd like We should investigate these, as well as others (such as K) to see what implementation is needed.

Describe alternatives you've considered n/a

Additional context Take a look at the code here: (https://github.com/cwensley/pablodraw/blob/c1df6febcc7fb6b2d9b7876fb783ff224e0e87f5/Source/Pablo/Formats/Character/Types/Ansi.load.cs)

cognitivegears commented 1 year ago

From what I've been able to figure out, it looks like:

Another set of characters that aren't CSI but we might need to deal with:

Yet another set that are not CSI sequences are ESC D and ESC M which work like CSI S and CSI T

Just wanted to see if you could confirm any of these before I put in code to handle them. Since I don't have any ANS files that uses them, I'll need to make samples to try to confirm.

cognitivegears commented 12 months ago

This should be addressed in PR #510 , just pending testing.

cognitivegears commented 11 months ago

Closing this issue as completed!