NuVotifier / NuVotifier

A fork of Votifier, with more robust code and vote forwarding
https://www.spigotmc.org/resources/nuvotifier.13449/
GNU General Public License v3.0
131 stars 98 forks source link

Maven repo #286

Open zax71 opened 2 years ago

zax71 commented 2 years ago

Information

Platform on which you run NuVotifier: Bukkit

Version of NuVotifier: 2.7.2

Relevant log: https://paste.gg/p/zax71/15252fd55deb42cfba42c306bb70ad9d

Details

Description
No usable maven repo's avaliable

Steps to reproduce
Compile a project with

<dependency>
            <groupId>com.github.NuVotifier.NuVotifier</groupId>
            <artifactId>nuvotifier-api</artifactId>
            <version>2.7.2</version>
            <scope>provided</scope>
</dependency>

Expected behavior
To not error with methords described in the wiki, works perfictally fine with a local copy of the NuVotifier jar

zax71 commented 2 years ago

https://github.com/astei/SuperbVote/blob/master/pom.xml Found a working repo in here, maybe the wiki should be changed?

quiquelhappy commented 2 years ago

did you guys manage to implement VoteListener? I'm able to import the lib with

        <dependency>
            <groupId>com.github.NuVotifier.NuVotifier</groupId>
            <artifactId>nuvotifier-bukkit</artifactId>
            <version>v2.7.3</version>
            <scope>provided</scope>
        </dependency>
        <repository>
            <id>jitpack</id>
            <url>https://jitpack.io</url>
        </repository>

but the interface isn't available

quiquelhappy commented 2 years ago

Please, update the wiki or allow for contributions @astei

        <dependency>
            <groupId>com.github.nuvotifier.NuVotifier</groupId>
            <artifactId>nuvotifier-bukkit</artifactId> <!-- fr? -->
            <version>2.6.0</version>
            <scope>provided</scope>
        </dependency>

this is what I'm currently using with jitpack

JustEli commented 2 years ago

There's no dependency to be found for velocity, i.e.

        <dependency>
            <groupId>com.github.NuVotifier.NuVotifier</groupId>
            <artifactId>nuvotifier-velocity</artifactId>
            <version>2.7.2</version>
            <scope>provided</scope>
        </dependency>

does not work. Just NuVotifier only provides api for bukkit, sponge and bungee.

Greenfoot5 commented 2 years ago

As per https://jitpack.io/#NuVotifier/NuVotifier, I managed to get it to work with

<project>
    <repositories>
        <repository>
            <id>jitpack</id>
            <url>https://jitpack.io</url>
        </repository>
    </repositories>

    <dependencies>
        <dependency>
            <groupId>com.github.NuVotifier.NuVotifier</groupId>
            <artifactId>nuvotifier-api</artifactId>
            <version>2.7.2</version>
        </dependency>
    </dependencies>
</project>

This managed to correctly import NuVotifier.

Joo200 commented 2 years ago

With my last Pull Requests there should be an easy way to add a artifactory repository to the existing Jenkins CI jobs. Unfortunatly I can't setup that and I don't want to provide my own repository for the CI jobs.

However I deployed the artifacts to my own repository until the maintainers from NuVotifier can find another repo for the maven artifacts.

The url is https://repo.terraconia.de/public/

The following artifacts are available: nuvotifier-api, nuvotifier-bukkit, nuvotifier-bungeecord, nuvotifier-common, nuvotifier-sponge, nuvotifier-velocity. Current version is 2.8.0-SNAPSHOT (I downgraded the version from 3.0.0-SNAPSHOT) as the latest changes are no major changes). You can use this repository until a repo for the maven artifacts is found when you don't want to use jitpack.