search

NuWro / nuwro

The main distribution of NuWro
GNU General Public License v3.0
13 stars 15 forks source link

Hip #15

Closed cthorpe123 closed 4 years ago

cthorpe123 commented 4 years ago

Merge hyperon production into main release.

cthorpe123 commented 4 years ago

Hi Kajetan,

I've made that file readable in vim, not sure what happened to it. I can either send that file to you or just push the change to my fork.

The c++17 and removal of the versioning was needed to get it to build on my machine.

The comment about target is to avoid prevent confusion over whether I'm working in the nucleons rest frame or the rest frame of the entire nucleus.

Thanks, Chris

From: Kajetan Niewczas notifications@github.com Sent: 25 March 2020 09:45 To: NuWro/nuwro nuwro@noreply.github.com Cc: Thorpe, Chris (Student) c.thorpe@lancaster.ac.uk; Author author@noreply.github.com Subject: [External] Re: [NuWro/nuwro] Hip (#15)

This email originated outside the University. Check before clicking links or attachments.

@KajetanNiewczas requested changes on this pull request.

Why the c++17 is needed and why the versioning is removed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNuWro%2Fnuwro%2Fpull%2F15%23pullrequestreview-380990911&data=02%7C01%7Cc.thorpe%40lancaster.ac.uk%7C3bde4a3c1b3447e08c9508d7d0a14a08%7C9c9bcd11977a4e9ca9a0bc734090164a%7C0%7C0%7C637207263484463731&sdata=PHHDSGhrkTI1NsktoAmphfOA6p0m4E%2FLdHKnrcCBWAc%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJ3L2FY36MG3M6O2V4YGNZDRJHHENANCNFSM4LR3DIFQ&data=02%7C01%7Cc.thorpe%40lancaster.ac.uk%7C3bde4a3c1b3447e08c9508d7d0a14a08%7C9c9bcd11977a4e9ca9a0bc734090164a%7C0%7C0%7C637207263484463731&sdata=3on26qRfGZpIrBnONAwLDPEEaMZxT8q%2BduiHHoP0YfY%3D&reserved=0.

KajetanNiewczas commented 4 years ago

Hi Kajetan, I've made that file readable in vim, not sure what happened to it. I can either send that file to you or just push the change to my fork. The c++17 and removal of the versioning was needed to get it to build on my machine. The comment about target is to avoid prevent confusion over whether I'm working in the nucleons rest frame or the rest frame of the entire nucleus. Thanks, Chris …

Sorry for a lot of mess everywhere. I'm not used to pull requests via GitHub website. I wanted to add more comments before sending but now I have not idea what you see and what you don't.

I need to think what to do about c++17. I already forgot what was the problem, but it's weird. Wasn't that caused by something else in the end? I remember something about trying to run cmake.