search

NuWro / nuwro

The main distribution of NuWro
GNU General Public License v3.0
14 stars 15 forks source link

Effective SF is not run even for Carbon or Oxygen #22

Closed Youjack closed 3 years ago

Youjack commented 3 years ago

https://github.com/NuWro/nuwro/blob/e3a877e4e1a91af034a14d411828f6c2e37a6385/src/nucleus.cc#L121

This expression is always false. It can be corrected by removing ! like assert ("effective SF can be run only for carbon and oxygen" &&(p==n && (p==6 || p==8)) );.

jsobczyk commented 3 years ago

Of course. Thank you!

wt., 26 paź 2021 o 08:38 Youjack @.***> napisał(a):

https://github.com/NuWro/nuwro/blob/e3a877e4e1a91af034a14d411828f6c2e37a6385/src/nucleus.cc#L121

This expression is always false. It can be corrected by removing ! like assert ("effective SF can be run only for carbon and oxygen" &&(p==n && (p==6 || p==8)) );.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NuWro/nuwro/issues/22, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3X7PXHPUYFUODSGT6GGP3UIZEFDANCNFSM5GW7JXDA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.