Windows cleanup - Githubissues

The host items (libbladeRF, bladeRF-cli, bladeRF-flash) cannot be build with /W due to the myriad of warnings.

Additionally, some Intel & MS static analysis logs, courtesy of LazyDodo.

Logs from 48b47936ca971b7879c13c97c30abdfeeb8a7d1e:


    ID              Problem Sources         State   Weight  Category
    P6              Uninitialized variable (possible)       peek.c          New     54      Initialization
    peek.c(92): error #12144: "max_address" is possibly uninitialized

    P2              Memory leak     fgets.c; recover.c              New     50      Memory
    recover.c(29): error #12121: memory leak: dynamic memory allocated at (file:fgets.c line:157) is not freed at this point

    P3              Memory leak     fgets.c; recover.c              New     50      Memory
    recover.c(32): error #12121: memory leak: dynamic memory allocated at (file:fgets.c line:157) is not freed at this point

    P5              Uninitialized variable (possible)       peek.c          New     44      Initialization
    peek.c(89): error #12144: "f" is possibly uninitialized

    P7              Uninitialized variable (possible)       poke.c          New     44      Initialization
    poke.c(83): error #12144: "f" is possibly uninitialized

    P8              Uninitialized variable (possible)       poke.c          New     44      Initialization
    poke.c(84): error #12144: "address" is possibly uninitialized

    P4              Uninitialized variable (possible)       cmd.c           New     24      Initialization
    cmd.c(465): error #12144: "argv[]" is possibly uninitialized

    P17             Unreachable statement   interactive.c           New     10      Unreachable code
    interactive.c(23): error #12192: unreachable statement

    P18             Unreachable statement   interactive.c           New     10      Unreachable code
    interactive.c(52): error #12192: unreachable statement

    P19             Unreachable statement   printset.c              New     10      Unreachable code
    printset.c(346): error #12192: unreachable statement

    P20             Unreachable statement   printset.c              New     10      Unreachable code
    printset.c(732): error #12192: unreachable statement

    P21             Unreachable statement   rxtx.c          New     10      Unreachable code
    rxtx.c(1226): error #12192: unreachable statement

    P14             Unused variable value   rxtx.c          New     8       Redundant code
    rxtx.c(1058): warning #12178: this value of "status" isn't used in the program

    P15             Unused variable value   rxtx.c          New     8       Redundant code
    rxtx.c(1084): warning #12178: this value of "status" isn't used in the program

    P16             Unused variable value   rxtx.c          New     8       Redundant code
    rxtx.c(1126): warning #12178: this value of "status" isn't used in the program

    P1              Default initialization  getopt_long.c           New     1       Other
    getopt_long.c(233): warning #12301: "optreset" is set to zero value by default

    P9              Unused subroutine       conversions.c           New     1       Unreachable code
    conversions.c(58): warning #12135: procedure "str2uint64" is never called

    P10             Unused subroutine       conversions.c           New     1       Unreachable code
    conversions.c(83): warning #12135: procedure "str2double" is never called

    P11             Unused subroutine       getopt.c                New     1       Unreachable code
    getopt.c(67): warning #12135: procedure "getopt" is never called

    P12             Unused subroutine       log.c           New     1       Unreachable code
    log.c(26): warning #12135: procedure "log_set_verbosity" is never called

    P13             Unused subroutine       log.c           New     1       Unreachable code
    log.c(8): warning #12135: procedure "log_write" is never called


    C6001   Using uninitialized memory      Using uninitialized memory 'saveptr'.   bladeRF-cli     cmd.c   456
                    'saveptr' is not initialized                    443
                    Skip this branch, (assume '!((line=_strdup(line_)))' is false)                  450
                    'saveptr' is used, but may not have been initialized                    456
    C6054   Zero termination missing        String 'lbuf' might not be zero-terminated.     bladeRF-cli     common.c        77
                    This expression may not zero-terminate 'lbuf'                   60
                    'lbuf' is an Output from 'memset' (declared at c:\program files (x86)\microsoft visual studio 11.0\vc\include\string.h:93)                      64
                    Skip this branch, (assume 's->script' is false)                 67
                    'lbuf' is an Input to 'strlen' (declared at c:\program files (x86)\microsoft visual studio 11.0\vc\include\string.h:117)                        77
                    'lbuf' is required to be zero-terminated by a SAL annotation on 'strlen'                        77
    C6059   Bad concatenation       Misuse of length parameter in call to 'strncat'.  Pass the number of remaining characters, not the buffer size of 'dev_ident'.  bladeRF-cli     open.c  46
                    'dev_ident' is an array                 40
                    Skip this branch, (assume '!dev_ident' is false)                        41
                    Enter this loop, (assume 'i<argc')                      45
                    'dev_ident' is an Input to 'strlen' (declared at c:\program files (x86)\microsoft visual studio 11.0\vc\include\string.h:117)                   46
                    Length argument to 'strncat' should be less than the length of 'dev_ident'                      46
    C6001   Using uninitialized memory      Using uninitialized memory 'saveptr'.   bladeRF-cli     rxtx.c  490
                    'saveptr' is not initialized                    466
                    Skip this branch, (assume '!bin_name' is false)                 477
                    Skip this branch, (assume '!bin' is false)                      482
                    Enter this loop, (assume '<branch condition>')                  487
                    'saveptr' is used, but may not have been initialized                    490
    C28253  Inconsistent annotation with prior instance     Inconsistent annotation for '_vsnprintf': _Param_(1) has 'SAL_post SAL_nullTerminated(__maybe)' on this instance. See c:\program files (x86)\microsoft visual studio 11.0\vc\include\stdio.h(340).      bladeRF-cli     stdio.h 349
    C6001   Using uninitialized memory      Using uninitialized memory 'saveptr_local'.     libbladerf_shared       device_identifier.c     136
                    'saveptr_local' is not initialized                      127
                    Skip this branch, (assume '!token' is false)                    131
                    'saveptr_local' is used, but may not have been initialized                      136
    C6001   Using uninitialized memory      Using uninitialized memory 'saveptr'.   libbladerf_shared       device_identifier.c     175
                    'saveptr' is not initialized                    154
                    Enter this loop, (assume '!!((d))')                     157
                    Skip this branch, (assume '<branch condition>' is false)                        164
                    Skip this branch, (assume '!dev_id' is false)                   170
                    'saveptr' is used, but may not have been initialized                    175
    C28253  Inconsistent annotation with prior instance     Inconsistent annotation for '_vsnprintf': _Param_(1) has 'SAL_post SAL_nullTerminated(__maybe)' on this instance. See c:\program files (x86)\microsoft visual studio 11.0\vc\include\stdio.h(340).      libbladerf_shared       stdio.h 349
    C6031   Return value ignored    Return value ignored: 'getchar'.        libbladeRF_test_repeater        repeater.c      524

Nuand / bladeRF

Windows cleanup #108