search

Nuand / bladeRF

bladeRF USB 3.0 Superspeed Software Defined Radio Source Code
http://nuand.com
Other
1.13k stars 455 forks source link

CLI TX start crashes for format=csv & invalid input #43

Closed jynik closed 11 years ago

jynik commented 11 years ago

On my TODO list after higher priority items.

To reproduce:

tx config file=/dev/urandom format=csv
tx start
Engidea commented 11 years ago

I can have a go at this, if you are not already doing it

jynik commented 11 years ago

Engidea -- have at it! :)

Tracking down (and implementing) stubbed out CLI commands (Issue #55) is another one that's not being worked on at the moment.

Engidea commented 11 years ago

It is done, available at Engidea/bladeRF and I can do a new pull request as soon as you cleared the previous one about Si5338

Engidea commented 11 years ago

This is closed, I need to find the correct way to attach a pull request to an Issue, is it even possible ?

jynik commented 11 years ago

This was pulled in with your other pull request in the following commit: https://github.com/Nuand/bladeRF/commit/57dfc83f194e51109400e1574df15937ac62d152

Mind confirming -- I will mark this closed on hearing the OK from you.

In the future, could you create separate branches per-issue basis, which will allow changes made in pull requests to remain isolated. (If you make a pull request and then keep committing to your branch that you made the pull request from, GitHub will automagically update that pull request with those additional commits...I think...)

Engidea commented 11 years ago

Yes, next activity (add rational clock) will use branches. I should have the repo setup correctly, now. As far as I can see the csv parsing produces correct results, and it should handle endianess correctly This as it is in current Engidea repo that is not yet merged, meaning that the csv parsing was ok but the endianess needed to be fixed with the "new" rules.