Heat map for current time

Nuanda / smogmapper

Smog Mapper

http://smogmapper.smogathon.pl/

1 stars 0 forks source link

Heat map for current time #25

Closed mkasztelnik closed 8 years ago

mkasztelnik commented 8 years ago

This PR includes:

current heatmap view
Fix for #24
Unify cache key for current and interval measurement readings

mkasztelnik commented 8 years ago

I have also improved a bit json generation for measurement readings (only required data are returned, nothing else).

nowakowski commented 8 years ago

:+1:

Nuanda commented 8 years ago

@nowakowski Piotr, thanks a lot for reviewing this :). However, let's assume that I have the sole right to merge PRs into master, ok? Perhaps I can force that somehow in GitHub, though I have no time to look for the exact switch :).

Still, I appreciate if you keep reviewing one another's PRs - should help detect bugs.

nowakowski commented 8 years ago

@Nuanda I'm completely :ok_hand: with this. :)

Nuanda commented 8 years ago

@mkasztelnik I'd like to ask for a slight modification - please do not remove markers for "current data heatmap" - remove them only for the animated 24 hours mode. Also - is it possible to make the current data heatmap be on/off (so once turned on it stays till turned off or the user clicks animated 24 hours)?

mkasztelnik commented 8 years ago

Ok I will do it. Maybe it would be better to change buttons for current heatmap into toogle button. Then current heatmap will be turned off only when user clicked toogle button once again or 24h heatmap will be turned on.

Similar toogle button can be made for markers - but this is a potential story for another PR :)

Nuanda commented 8 years ago

@mkasztelnik Ok, I'll merge it for now, will leave the branch in case you'd like to continue to use it.