search

Nuanda / smogmapper

Smog Mapper
http://smogmapper.smogathon.pl/
1 stars 0 forks source link

Big chart in modal to show sensor readings #59

Closed Nuanda closed 8 years ago

Nuanda commented 8 years ago

@mkasztelnik Marek, let's work on it together. I pushed here some initial code that fixes devoops css modal problems. Feel free to add further things here, but get in touch first with me, so we do not duplicate work :).

Basic structure is there - you should be able to show a modal by clicking a sensor marker on the map. You are free to work with the charts there in order to show all data on a single chart.

mkasztelnik commented 8 years ago

To convert it into one chart I need to make changes in JS which are quite difficult using rails partials (e.g. iteration inside JS template to create multiple Y axis). That is why I need to change the way how popup is created: json response from the server and JS code on the client side. That is why I believe this can be already merged into master and I will create separate PR with one chart per sensor modal.