search

Nubescope / sinon-mongoose

Extend Sinon stubs for Mongoose methods to test chained methods easily
MIT License
87 stars 29 forks source link

Upgrade of mongoose to +5.5.x #48

Open YasharF opened 5 years ago

YasharF commented 5 years ago

Upgrade of mongoose was omitted from https://github.com/underscopeio/sinon-mongoose/pull/46 even though npm audit calls it out to have an issue. I did make an attempt to do the upgrade in package.json, but it looks like that there is a breaking change and it causes npm test to fail.

gaguirre commented 5 years ago

Thanks for reporting this. Let me know if you've some more info about it.

YasharF commented 5 years ago

By some trial and error when running npm test, I have narrowed that 5.3.16 -> 5.4.0 is the breaking change. The three tests that failed are the "verify chained" tests.

Here is the changelog for mongoose at that point: https://github.com/Automattic/mongoose/blob/master/History.md#540--2018-12-14

YasharF commented 5 years ago

With https://github.com/underscopeio/sinon-mongoose/pull/49 mongoose is getting bumped to 5.3.16 by the way.

dhuang612 commented 5 years ago

I'll work on this

dhuang612 commented 5 years ago

Hi,

I created PR #53 with all tests working now. Thanks