Nuchaz / BiblioCraft

50 stars 51 forks source link

Can't dupe enchanted books #607

Open raindropworks opened 6 years ago

raindropworks commented 6 years ago

MC 1.12.2 Forge 14.23.4.2178 Bibliocraft 2.4.5

Build typesetting table, place chases in top slot, enchanted book in bottom left spot. Apply button to front of table (per webpage) and click to apply redstone pulse.

What's expected: Book is consumed and an enchanted Print Press Plate is added to the lower right

What actually happens: Book remains, no XP is drained, but a non-enchanted Print Press Plate is added to the lower right. When in inventory, Print Press Plate has subtext 'Select a book'

Additionally, server output gives the following error if trying to use the Press Plate in the printing press:

[08:47:36] [Server thread/INFO] [STDOUT]: [jds.bibliocraft.tileentities.TileEntityPrintPress:smeltItem:374]: This is not a valid book name!

rremer commented 6 years ago

MC 1.12.2 Forge 14.23.4.2707 Bibliocraft 2.4.4

The wiki actually indicates that you should just be able to shift + click the enchanted book, and that's what saps your levels. That said, the Typesetting Table appears not to work for minecraft:written_book as well, so this is a more general issue.

JEI shows that's there is one "Enchanted Plate" item (bibliocraft:enchantedplate) with a description of "Not Valid'. That is the item you get when just give a redstone signal as described by @minakitty . That in itself may not be a bug, but is the result of trying to work around the bug.

The book selection GUI doesn't seem to show anything with written books, and they create the same item as described above: bibliocraft:printplate with a tag of {bookName:"Select a book.."}.

The enchanted plates show up in JEI with the relevant enchantments on them (for instance bibliocraft:enchantedplate {ench:[{lvl:1s,id:34s}]} is an Enchanted Plate with Unbreaking I. What's interesting about all these entries is that they all have the description of "Not Valid", which is all we can get from the Typesetting Table.

Hopefully this helps you replicate the bug @Nuchaz , let us know if you have a different preferred bug-reporting method or if we can provide more data/testing.

raindropworks commented 6 years ago

So, I guess the typesetting table isn't bugged, but the wiki may be? Various mod spotlight videos said to shift-right click on the book to make the enchanted plate, but the CarryOn mod was interfering with that. I blacklisted the typesetting table and it fixed my problem, but the webpage seems to have incorrect information?

rremer commented 6 years ago

Ah, good catch @minakitty , for me as well it was another mod overloading shift + click. More specifically, it seems that since off-hand was introduced to minecraft, pretty much anything will make the Typesetting Table seem bugged when it isn't, the shift + click is just getting applied to the off-hand instead.

raindropworks commented 6 years ago

I've heard the off-hand issue a few times already, and was already expecting to have to de-equip my shield. I know the mod is working-as-intended, but it does feel like with the vanilla improvements there may be a more intelligent way to do it now