search

NuckChorris / assault

A simple customizable battery indicator ported to as many WMs, docks, and platforms as possible.
MIT License
36 stars 8 forks source link

awesomewm: Setting to specify the prefix of the battery current and full charge path #13

Closed loathingKernel closed 9 years ago

loathingKernel commented 9 years ago

In my case, the battery charge paths where named "charge_now" and "charge_full" rather than "energy_now" and "energy_full". This change enables the user to set their own prefix if it is needed.

NuckChorris commented 9 years ago

Great PR, though the behavior should probably match the behavior in C. I had kind of assumed it did, I guess I was wrong >_>

loathingKernel commented 9 years ago

I agree completely that making it not require a setting is better. This commit matches more or less directly the way it is being done in the C code. Should I try to reduce code duplication while still having the same behavior or do you prefer it to be similar to the way it is done in C?

NuckChorris commented 9 years ago

Feel free to write it not idiomatically, Lua is certainly not C

ghost commented 9 years ago

:+1: