search

Nuclei-Software / nuclei-sdk

Nuclei RISC-V Software Development Kit
https://doc.nucleisys.com/nuclei_sdk
Apache License 2.0
117 stars 50 forks source link

board: function renaming / defining for LEDs and Keys to new API. #17

Closed RomanBuchert closed 3 years ago

RomanBuchert commented 3 years ago

Described in #15

tuupola commented 3 years ago

https://doc.nucleisys.com/nuclei_sdk/contribute.html#git-commit-guide

Commit messages should be present tense in imperative mood. Ie commit message should answer to question "Applying this PR will: xxx". For example "Applying this PR will: Correct Indentation " or "Applying this PR will: Rename functions according to new API "

This is needed so that project will have a nice clean commit history.

RomanBuchert commented 3 years ago

Thanks for your update.

Could you also help to format the code of old gd32v board(rvstar and eval) in this PR, there are some code lines not aligned, and some code are mixed with space and tab, it is included previously by me, not a good start.

Thanks Huaqi

... I hope I got all the TABs.