Closed tuupola closed 3 years ago
Hi, @tuupola,
gcc_gd32vf103_flashxip.ld
to not change too much in Makefile.soc.gd32vf103
.Yes, it has a GD32VF103CBT6.
Just a quick note. I have not forgotten this, just busy with other things atm.
After some testing this should be ready.
One question though. Currently there is some inconsistencies with naming of things. There is LEDG_PIN
and KEY_A_PIN
. There is both LED1
and LED_1
but only KEY_A
. I think it would be good idea to choose one naming scheme and stick to it.
Which one should I use?
It is still ok to break BC when bumping SDK from 0.3.x
to 0.4.0
. I also don't think there is too much software which will break because of this, and if they do the fix is really easy.
Also the board image in documentation is taken from manufacture website. If this is a problem I can take a photo of the board myself.
Hi @tuupola , I prefer to user must define the following enums:
typedef enum
{
LED_1 = 0,
LED_2 = 1,
LED_3 = 2,
} led_typedef_enum;
typedef enum
{
KEY_A = 0,
KEY_B = 1,
KEY_C = 2,
} key_typedef_enum;
typedef enum
{
KEY_MODE_GPIO = 0,
KEY_MODE_EXTI = 1
} keymode_typedef_enum;
If you have more than 3 leds, and keys, the above should be defined.
Thanks Huaqi
I test compiled and uploaded everything in application folder. There are some unrelated compiler warnings with demo_dsp and freertos/demo . Everything works fine with my TTGO T-Display-GD32 board though. I think this should be ready for merging.
Done
This PR adds support for the LILYGO® TTGO T-Display-GD32 board. PR is still work in progress, documentation etc is missing.
Few questions.
gd32vf103c_t_display
) or should it be something else?gcc_gd32vf103_flashxip.ld
like now or should it begcc_gd32vf103xb_flashxip.ld
like with Longan Nano? The latter version require also extra conditional sentence inMakefile.soc.gd32vf103
.