nmsis_gcc.h disables gcc warnings

Nuclei-Software / nuclei-sdk

Nuclei RISC-V Software Development Kit

https://doc.nucleisys.com/nuclei_sdk

Apache License 2.0

117 stars 50 forks source link

nmsis_gcc.h disables gcc warnings #32

Closed DagAgren closed 2 years ago

DagAgren commented 2 years ago

nmsis_gcc.h forcibly disables some warnings:

https://github.com/Nuclei-Software/nuclei-sdk/blob/master/NMSIS/Core/Include/nmsis_gcc.h#L46

This is very bad form for a system library. I want those warnings in my code, I do not want them silently disabled. If any headers are causing warnings, that code should be fixed, and warnings should not be silenced.

fanghuaqi commented 2 years ago

Will evalute on it and change it

fanghuaqi commented 2 years ago

Removed these #pragma GCC diagnostic