search

Nuclei-Software / nuclei-sdk

Nuclei RISC-V Software Development Kit
https://doc.nucleisys.com/nuclei_sdk
Apache License 2.0
117 stars 50 forks source link

build: fix bugs in "upload" target, remove useless semicolons. #55

Closed kfggww closed 11 months ago

kfggww commented 11 months ago

1) I found that there are extra semicolons in the "GDBREMOTE" and "OPENOCD_PORT_ARGS" variables of Makefile.conf, since the "OPENOCD_CMD_ARGS" is empty, an useless semicolon will be leaved.

2) $< is missing in the upload target of Makefile.rules

I have tested these changes in gd32vf103_rv_star board.

kfggww commented 11 months ago

I tested on rv_star board again, it seems that no need to add $<, since target elf file is already specified in the GDB_UPLOAD_CMDS variable. The extra semicolons are also OK.

kfggww commented 11 months ago

when I test this board the first time, it does fail to upload, maybe there are some hidden issues of my development environment.