search

NucleoidMC / fantasy

Library to support creating dimensions at runtime
GNU Lesser General Public License v3.0
95 stars 26 forks source link

Update to 1.21 #51

Closed pisaiah closed 2 months ago

pisaiah commented 3 months ago

small changes. just thought i'd help out.

fantasy-0.6.0+1.21-pre2.jar

edit: works on 1.21 release.

LCLPYT commented 2 months ago

When running the "Testmod Client" the client crashes upon entering a singleplayer world:

[20:55:08] [Server thread/ERROR] (Minecraft) Encountered an unexpected exception
 java.lang.NullPointerException: Cannot invoke "net.minecraft.world.chunk.ChunkGenerationContext.generator()" because "this.generationContext" is null
    at net.minecraft.server.world.ServerChunkLoadingManager.getChunkGenerator(ServerChunkLoadingManager.java:211) ~[minecraft-merged-b6d11c46c6-1.21-net.fabricmc.yarn.1_21.1.21+build.1-v2.jar:?]
    at net.minecraft.server.world.ServerChunkLoadingManager.wrapOperation$zfo000$fantasy$useProvidedChunkGeneratorSettings(ServerChunkLoadingManager.java:1291) ~[minecraft-merged-b6d11c46c6-1.21-net.fabricmc.yarn.1_21.1.21+build.1-v2.jar:?]
    at net.minecraft.server.world.ServerChunkLoadingManager.<init>(ServerChunkLoadingManager.java:183) ~[minecraft-merged-b6d11c46c6-1.21-net.fabricmc.yarn.1_21.1.21+build.1-v2.jar:?]
    at net.minecraft.server.world.ServerChunkManager.<init>(ServerChunkManager.java:84) ~[minecraft-merged-b6d11c46c6-1.21-net.fabricmc.yarn.1_21.1.21+build.1-v2.jar:?]
    at net.minecraft.server.world.ServerWorld.<init>(ServerWorld.java:242) ~[minecraft-merged-b6d11c46c6-1.21-net.fabricmc.yarn.1_21.1.21+build.1-v2.jar:?]
    at xyz.nucleoid.fantasy.RuntimeWorld.<init>(RuntimeWorld.java:29) ~[main/:?]
    at xyz.nucleoid.fantasy.test.CustomWorld.<init>(CustomWorld.java:17) ~[testmod/:?]
    at xyz.nucleoid.fantasy.RuntimeWorldManager.add(RuntimeWorldManager.java:49) ~[main/:?]
    at xyz.nucleoid.fantasy.Fantasy.addTemporaryWorld(Fantasy.java:175) ~[main/:?]
    at xyz.nucleoid.fantasy.Fantasy.openTemporaryWorld(Fantasy.java:127) ~[main/:?]
    at xyz.nucleoid.fantasy.Fantasy.openTemporaryWorld(Fantasy.java:111) ~[main/:?]
    at xyz.nucleoid.fantasy.test.FantasyInitializer.lambda$onInitialize$0(FantasyInitializer.java:34) ~[testmod/:?]
    at net.fabricmc.fabric.api.event.lifecycle.v1.ServerLifecycleEvents.lambda$static$2(ServerLifecycleEvents.java:49) ~[fabric-lifecycle-events-v1-2.3.9+98a7dbbb90.jar:?]
    at net.minecraft.server.MinecraftServer.handler$zkk000$fabric-lifecycle-events-v1$afterSetupServer(MinecraftServer.java:4642) ~[minecraft-merged-b6d11c46c6-1.21-net.fabricmc.yarn.1_21.1.21+build.1-v2.jar:?]
    at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:668) ~[minecraft-merged-b6d11c46c6-1.21-net.fabricmc.yarn.1_21.1.21+build.1-v2.jar:?]
    at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281) ~[minecraft-merged-b6d11c46c6-1.21-net.fabricmc.yarn.1_21.1.21+build.1-v2.jar:?]
    at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
LCLPYT commented 2 months ago

I created a PR that fixes this: https://github.com/IsaiahMC/fantasy/pull/1