search

Nucleoprotein / PeteOpenGL2Tweak

Tweaker for PeteOpenGL2 plugin with GTE Accuracy Hack and xBRZ Texture Filter
45 stars 10 forks source link

Better ''GTE Accuracy'' implementation #4

Open ADormant opened 8 years ago

ADormant commented 8 years ago

Is is possible to add this implementation to Tweak?

I'd also like to point out that gligli's original GTE accuracy method offered much better quality than the current implementation, even without depth accuracy. Enabling gligli's depth option made it almost perfect. Why was a different method chosen? They both seem to use similar resources.

https://pcsxr.codeplex.com/discussions/264234

Nucleoprotein commented 8 years ago

This is almost same as current GTE Hack, with some additional tweaks and -reduced- precision (shift by 11 bit before divide).

EDIT: I applied this - same effect as current implementation.

ADormant commented 8 years ago

What about that depth information? Some people reported better image quality in psx_enhance!_v2.rar even without depth.

Nucleoprotein commented 8 years ago

Is not better at all, is exactly same or worse. 2D is broken too. Depth is only used for strange comparison that ignores all vertices at higher depths, vertex is added only if z<=enh->depth[ey][ex]

ADormant commented 8 years ago

@tapcio You can try this but it is not finshed yet. https://github.com/simias/beetle-psx-libretro/commit/2b5c6f623affe5fffa1ddcb6894dbaf25d91d43d

Nucleoprotein commented 8 years ago

This can be better, because they invalidate values after use. Also this seems to be finished.

ADormant commented 8 years ago

https://github.com/simias/rustation/commit/4c6933604d23aed3e874ad58427d8fd3b563ee9e https://github.com/simias/rustation/commit/aea0850102b32c8e3ccd86cf434d1f0e7666e2c9 https://github.com/simias/rustation/commit/7d10ed3c548bd2133d2e7fc5b5efd777c3782b48 https://github.com/simias/rustation/commit/14195bc46802c91248de802ceaa967a2f7d8fa3b https://github.com/simias/rustation/commit/10d1ae01c1a651a8949539cd283f448e24e4940c https://github.com/libretro/beetle-psx-libretro/commit/9cc93ebde6a866d82c8d4d00019f52c810ebe597 https://github.com/simias/beetle-psx-libretro/commit/2b5c6f623affe5fffa1ddcb6894dbaf25d91d43d

Nucleoprotein commented 8 years ago

https://github.com/libretro/beetle-psx-libretro/commit/9cc93ebde6a866d82c8d4d00019f52c810ebe597

Nucleoprotein commented 8 years ago

RUST is terrible to read... I do not know it, and I do not know if I want to ... It like ObjC ...