NucleusPowered / Nucleus

The Ultimate Essentials Plugin for Sponge.
http://nucleuspowered.org
MIT License
160 stars 69 forks source link

Command /invsee might cause server crash if open an offline player's inv. #1459

Closed Simba98 closed 4 years ago

Simba98 commented 4 years ago

What is the bug? If I used /invsee PlayerName to see an offline player's inventory, the server might crash after a little moment. Not immediately, server would crash after 60s (might be).

What version of Nucleus are you running? Nucleus version 1.14.1-S7.1 (built from commit fed256a8)

What version of Sponge are you running? forge-1.12.2-14.23.5.2847 spongeforge-1.12.2-2838-7.1.7

Provide a link to the file generated by /nucleus info https://pastebin.com/e8dyjpiD

To Reproduce Steps to reproduce the behavior:

  1. Enter /invsee PlayerName (make sure the player is offline)
  2. Edit their inventories.
  3. Close it
  4. Logout or Wait for a moment
  5. Server might crash

(PS: I found the edit inv action is effected after I restart the server)

Expected behavior Not Crash

Logs Crash Report https://pastebin.com/qvEhhtCc

Log File https://pastebin.com/rjMi1Bps

dualspiral commented 4 years ago

Apologies for not getting to this sooner. This is actually likely a Sponge issue to be honest - that user is not initialised error is in particular interesting.

The crash log has disappeared, but part of the log is there, thankfully. I would advise you update Sponge and if it continues, come back to me.

dualspiral commented 4 years ago

Ah, yes, forgot this was here. This was a Sponge issue, make sure you're on the latest recommended.