search

NucleusPowered / Nucleus

The Ultimate Essentials Plugin for Sponge.
http://nucleuspowered.org
MIT License
158 stars 70 forks source link

Fix NPE caused by config not being initialized. #1643

Closed DrZoddiak closed 2 years ago

DrZoddiak commented 2 years ago
dualspiral commented 2 years ago

While this kind of fixes the stack trace, it probably doesn't fix the actual issue at hand because the reloadable should have fired before this point. I looked at the stacktrace in Discord and noticed it's SF being used, I wonder if the StartingEngineEvent<Server> isn't firing.

dualspiral commented 2 years ago

(i.e. it worked on SpongeVanilla)

dualspiral commented 2 years ago

It fires it, I logged the event happening: [12:37:42] [Server thread/INFO] [lifecycle-events/]: StartingEngineEvent

Gonna have to make sure reload events are firing.

dualspiral commented 2 years ago

I've opted to do this for now, because if this is the case, reloadables haven't fired so I need to do it manually. cheers for looking though!