NucleusPowered / Nucleus

The Ultimate Essentials Plugin for Sponge.
http://nucleuspowered.org
MIT License
160 stars 69 forks source link

/invsee not working with mixins installed #506

Closed AussieWarGod closed 7 years ago

AussieWarGod commented 7 years ago

it is doing the same thing it was doing without mixins, i will provide nucleus info dump as well. let me know if you need logs and i can pull some for you. This occurs across all our servers/modpacks.

Info dump: nucleus-info-20161206-041842.txt

Sponge: 1.10.2-2123-5.1.0-BETA-1925 Forge: 12.18.2.2124 Nucleus: 0.15.0-5.0 Nucleus mixins: 0.14.0-5.0-SNAPSHOT and i also tried 0.15.0-5.0

dualspiral commented 7 years ago

What other mod packs do you have that show this problem? Also, if you've got the fml-server.log, that might be useful to see which of your mods are core mods and might cause the issue.

AussieWarGod commented 7 years ago

I will test thisafternoon and get back to you, so far i have only tested dw110

AussieWarGod commented 7 years ago

Here are the FML log files, sorry i must have got distracted last night.

We run Infinity Lite, Hermitpack and Direwolf20 1.10

Invsee doesn't work on any of these with mixins installed. we also updated to sponge 1963 and the issue still occurred. i am completely open to user error or plugin conflict here but from what i can gather both nucleus and mixins is installed correctly.

fml-server-latest Direwolf20 110.txt fml-server-latest Infinity Lite.txt fml-server-latest HermitPack.txt

dualspiral commented 7 years ago

It's definitely a mod conflict. NucleusMixins directly modifies the inventory code to allow /invsee to work correctly, another core mod will be overwriting my changes - I'm just trying to work out which one(s) would do that and see if there is a way around it.

AussieWarGod commented 7 years ago

I appreciate the effort, sorry for the inconvenience.

SnowBlitzz commented 7 years ago

Works fine for me on SF 2003, forge 2171 - Nucleus 0.16.3 with mixins 0.15.0 and is still working fine on the current development versions.

dualspiral commented 7 years ago

Some good news, for 1.11, I won't need to provide a Mixin plugin for /invsee. This isn't the case for 1.10.x yet, but if it doesn't end up in 1.10.x, I'll see about incorporating the fix into the mixins - though I really hope it does.

https://github.com/SpongePowered/SpongeCommon/commit/11c1cc929dfba1fa35ea53f4ab935c7d9a0ff839

Brend-Smits commented 7 years ago

Running the latest SpongeForge & Latest Nucleus, I still can't use /invsee

dualspiral commented 7 years ago

@Rubbertjuh Did you install the Nucleus Mixins plugin? - you make no mention of it there.

Brend-Smits commented 7 years ago

@dualspiral I have it installed. sorry ^^

dualspiral commented 7 years ago

What Modpack are you running?

Brend-Smits commented 7 years ago

Sky Factory 3

dualspiral commented 7 years ago

We figured it out!

It's important to note that Nucleus Mixins is a MOD, not a PLUGIN, and must go in your mods folder, not your plugin folder!

Please move NucleusMixins into the mods folder and try again.