NucleusPowered / Nucleus

The Ultimate Essentials Plugin for Sponge.
http://nucleuspowered.org
MIT License
160 stars 69 forks source link

Per kit Permission #949

Open Yann151924 opened 6 years ago

Yann151924 commented 6 years ago

Can be good to have full separate permission per kit like this :

nicekitname is the kit name

It's some example but all permission link to the kit with separate can be good to make conditionnal or more powerfull for server owner. Like the donateur can view vip kit but can' buy it and vip can view the donator kit and don't have any cost or warmup to take it.

Don't know if it's quite clear but i make my best :)

Rasgnarok commented 6 years ago

I feel as if this an over-extension of the current kit module, and probably best left as a seperate plugin. Nucleus does have an API, and assuming that the hooks are there (or could be made!), such an extension of the per-kit perm management is perhaps too 'niche' for Nucleus. I believe clever usage of the Nucleus API and Luckperms' meta system would vastly improve what you want to do with this.

Yann151924 commented 6 years ago

Hum could be a solution but i don't have a good level in java to do this.

dualspiral commented 6 years ago

I'm not completely against this - but it is somewhat niche and I don't want to spend a lot of time on this when there are many other things that need to be done right now. If anyone wants to do this sooner, I'd happily review a PR.

I'd be more keen, if someone was to take this on, on the cost/cooldown exemptions being options, so rather than specifying an exemption, you'd specify the option nucleus.kit.nicekitname.cooldown to be, say 4, for 4 seconds, overriding the norm. Same with cost, some groups might have a half price kit. That way, this becomes a lot more flexible.

dualspiral commented 6 years ago

(for anyone interested, the checks would most likely go in here)