NuggoDEV / CountersPlus

A combination of widely-used counters, all configurable in one Beat Saber mod.
MIT License
131 stars 33 forks source link

Fix custom Counters+ counter conflicts when registering settings into Heck #115

Closed ErisApps closed 2 years ago

ErisApps commented 2 years ago

The internal configs for custom counters were all using the default value of "Unknown" for the DisplayName property. However , this will result in conflicts when Heck and multiple custom counters are installed. When registering the settings into Heck, we end up with settings collisions due to the custom counters sharing the same internal config model (and thus the same properties) as well as the DisplayName.

The problem is thus solved by explicitly setting the DisplayName for custom counters when creating the config.

Issue was discovered by @ChirpyMisha 🙂