NuggoDEV / CountersPlus

A combination of widely-used counters, all configurable in one Beat Saber mod.
MIT License
131 stars 33 forks source link

Game crash on faulty Custom Counter #116

Open ChirpyMisha opened 2 years ago

ChirpyMisha commented 2 years ago

It's up to debate whether this is an issue with the mod or not. Anyway, when the "CounterLocation", "Resource", or "Host" paths contain a typo in the manifest.json of a custom counter, then Counters+ will crash. To me the error messages are a bit vague (see below). Possibly adding the custom counter in a try-catch or checking if the path is correct can give a much more informative log message and then the custom counter can be ignored.

I made a small change in one of my counters while working on another counter, and I thought I somehow caused an incompatibility conflict or something like that. In the end I forgot that I changed the namespace of my counter and didn't update it in the manifest file. So I spent a lot of time looking for a fix in the wrong counter. Of course it's my fault for making the mistake. I can't deny that. But imho I think Counters+ should be able to handle those exceptions 😅

Example of the first 3 error messages: [CRITICAL @ 15:20:30 | UnityEngine] NullReferenceException: Object reference not set to an instance of an object [CRITICAL @ 15:20:30 | UnityEngine] CountersPlus.Installers.CountersInstaller.AddCustomCounter (CountersPlus.Custom.CustomCounter customCounter, System.Type counterType) (at :0) [CRITICAL @ 15:20:30 | UnityEngine] CountersPlus.Installers.CountersInstaller.InstallBindings () (at :0)