NuggoDEV / CountersPlus

A combination of widely-used counters, all configurable in one Beat Saber mod.
MIT License
131 stars 33 forks source link

Per-Environment Base Offsets for 'Parent to Base Game UI' (Plus others.) #133

Open Xentha opened 1 year ago

Xentha commented 1 year ago

Is it because of an issue? The base game UI is not in the same orientation for every environment. For example, EDM makes the UI elements smaller and by extension, lower. Counters+ UI elements do not account for this even with 'parent to base game UI' and the setting that attaches the Z position both on.

Describe your solution Per-environment size/position offsets that are built into the code. (New environments would of course just use the default environment value prior to updating the mod for them.) As long as the UI follows the differences in base UI positions properly, there shouldn't need to be any change to the in-game customization settings. Disabling the 'parent' option should be sufficient to disable this automatic adjustment as well.

A programmer yourself? I've only worked extensively with the code base in Second Life, almost a decade ago, which used 'LSL' and 'Mono'. I've heard they're a mix of Java and C# however, and I do intend to learn how to code mods eventually, so I may in fact eventually come help with this, as there are other 'enhancements' that I have in mind for this mod.

Other enhancements in mind;

Caeden117 commented 1 year ago

It sounds like an existing mechanism to try and automatically find those environment offsets broke with a recent update (or recent environment). I'll have to look into it.

Xentha commented 1 year ago

Oh! Well hopefully it's a simple fix then, as, yeah, specifically with the EDM environment if I have something sitting below the combo counter, said counter will have sunken down and overlapped that hud element.

If it matters: I am on 1.27 via Legacy Launcher, and using Counters+ v2.3.2.0

Also here's an example - again, if it helps at all. Example