search

NuggoDEV / CountersPlus

A combination of widely-used counters, all configurable in one Beat Saber mod.
MIT License
131 stars 33 forks source link

Fix for 1.31.1 #134

Closed aaronjamt closed 11 months ago

aaronjamt commented 11 months ago

These changes allow the project to compile successfully for 1.31.1 and actually do work in game

aaronjamt commented 11 months ago

Just converted this to a draft, turns out that it works fine in normal gameplay but the settings menu is broken.

aaronjamt commented 11 months ago

It's something to do with the BSML CustomListTableData, specifically the .data property. For some reason, both the getter and setter seem to just... not exist? BSML throws an error when trying to access the property, saying that it is trying to Invoke .get_data() or .set_data() via reflection.

aaronjamt commented 11 months ago

Fixed that, we're good for a merge now (and I now think the CustomListTableData think was an unrelated issue specific to my machine)