search

NuggoDEV / CountersPlus

A combination of widely-used counters, all configurable in one Beat Saber mod.
MIT License
131 stars 33 forks source link

CustomCounters not working anymore since 2.3.4 #137

Closed no-1-noob closed 8 months ago

no-1-noob commented 9 months ago

The Functionality of creating custom counters in other mods is not working anymore (They basically do not get recpgnized as existing)

I saw in the commits, that the CustomCounterFeature.cs has been deleted in this commit and the IPA.DefineFeature removed from the manifest.

Did this have a reasoning? I tried to patch it back into C+ and it seems to load CustomCounters just fine (after adding IPA.Definefeature and CustomCounterFeature.cs), but maybe i am overlooking some problem you encounted while fixing C+ for 1.34?

Best regards

Caeden117 commented 9 months ago

If intentional, this breaks semver and should necessitate a major version bump.

NuggoDEV commented 8 months ago

Oh? I'll look into it @no-1-noob once I get a chance, apologies for any issues

NuggoDEV commented 8 months ago

@no-1-noob I can see the issue I had previously, when compiling, I faced the CS0115 (no suitable method to override) error on the Initialize function.

I didn't realize this was actually a core component for counters to work

NuggoDEV commented 8 months ago

The errors image

image

denpadokei commented 8 months ago

This occurs because there is a difference in the versions of Newtonsoft.Json referenced by IPA.Loader and CountersPlus. You should be able to build by setting the SpecificVersion entry in csproj to True and specifying 13.0.0.0.

NuggoDEV commented 8 months ago

Epic, 2.3.5 is out now.