keep CompleteMultipartUpload alive

Nugine / s3s

S3 Service Adapter

Apache License 2.0

132 stars 33 forks source link

keep CompleteMultipartUpload alive #141

Closed lperlaki closed 3 months ago

lperlaki commented 6 months ago

reopen of #31

changes the response body from the CompleteMultipartUpload Operation to a custom KeepAliveBody that sends a whitespace every 100 milliseconds to keep the request alive

but now with hyper support for trailers

fixes #30

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Nugine commented 6 months ago

We have a new failure in e2e tests. Maybe a compatibility issue?

{
  "name": "aws-sdk-php",
  "function": "uploadPart ( array $params = [] )",
  "args": {
    "Bucket": "aws-sdk-php-65f762b387bb0",
    "Object": "obj1"
  },
  "duration": "261",
  "status": "FAIL",
  "error": "Your proposed upload is smaller than the minimum allowed object size."
}

Nugine commented 5 months ago

I'm busy for the next three weeks. I'll look into the e2e test failure after that. Sorry about the delay but finally we will complete.

Nugine commented 3 months ago

It seems that we hit a bug in aws-sdk-php.

https://github.com/aws/aws-sdk-php/pull/2932

I'll allow the failed test and merge this PR soon.