Nuitka / Nuitka-Action

Action to build with Nuitka on GitHub in your workflows
MIT License
111 stars 22 forks source link

Add `--include-package-data` option #6

Closed fedebotu closed 1 year ago

fedebotu commented 1 year ago

As in the title, --include-package-data option can now be provided as well. The reason why I am making this pull request is that I needed selenium's data to be included (from Nuitka's issues), so I added the option :)

kayhayen commented 1 year ago

@fedebotu if you have a list of the required data files, you may also want to consider making a PR that adds them to Nuitka's Yaml package configuration, we are going to launch a series of posts about the format, but actually for data files and dirs, it's pretty straight-forward.

fedebotu commented 1 year ago

@kayhayen If I understand correctly what you are saying, I believe it shouldn't be necessary. For the required data files, they should be automatically included when using the --include-package-data option. Using --include-package-data selenium automatically includes Selenium's data without any need for external files (as mentioned here)

Radomur commented 6 months ago

"--include-package-data selenium"

I have an error writing: "Usage: main.py [--module] [--run] [options] main_module.py main.py: error: The '--include-package-data' option requires an argument with '--include-package-data='."

Windows 10 64bit

kayhayen commented 6 months ago

@Radomur poting below closed issues is a surefire way to get ignored, please open a new issue

dediunique commented 3 months ago

@Radomur You have to do --include-package-data=selenium

Like the command explanation itself lists.

kayhayen commented 3 months ago

This is the wrong repo for Nuitka issues, selenium has recently seen a PR to do this automatically, checkout main repo.