Closed NukeRusich closed 9 years ago
Comment by julianlam Tuesday Mar 18, 2014 at 18:35 GMT
Whatever we decide, it has to be mobile friendly. The modal right now goes full screen on mobile, which works.
To this, I'd add that the chat subsystem should not use notifications anymore, as the chat list is now a discrete dropdown. Perhaps we can mark it "active" instead. @barisusakli ?
Comment by cnvo Tuesday Mar 18, 2014 at 19:08 GMT
How about when at a certain viewport (mobile) it can go to 100% width, absolute, top bottom left right at 0 for mobile friendly. If you guys need any help with this depending on if you go further with this later or not, I would be glad to help. I made a mockup, please excuse my sloppiness. I do this when I design, lol.
For reference, it's pretty basic.
Comment by julianlam Tuesday Mar 18, 2014 at 19:13 GMT
Love the mockup, by the way :+1: Definitely helps visualise this.
If we're going ahead with this, I'd recommend we also add a button to expand the chat to full screen. This would probably use the same CSS, and using mixins in LESS, is totally doable:
.chat-fullscreen
.chat-fullscreen
Comment by psychobunny Tuesday Mar 18, 2014 at 19:57 GMT
I also have to say I occasionally miss chats (the new sound alert will help a lot) - so a more "active" looking feel on the taskbar will be nice (currently goes from grey to darker grey, doesn't capture attention as much)
Comment by crdnl Thursday Apr 03, 2014 at 18:43 GMT
What if the the button inverts? so from #fff to #000
Comment by julianlam Tuesday May 27, 2014 at 18:30 GMT
@cnvo Is this in your theme already? We'd love to have this in vanilla... hint hint :laughing:
Comment by cnvo Tuesday May 27, 2014 at 18:56 GMT
Yes, I finished the design yesterday. I had to remove all modal-
strings from chat.js
and change them to chat-
instead because it isn't a modal anymore. This design breaks all of the other designs as well as the strings are changed. I couldn't find an easier way to do this since the modals wouldn't play nicely so I scrapped it altogether and redid the whole thing.
Would be nice though to have the modals as an option for this. :+1: If you guys could make a rough code for this and a quick and dirty design I'll clean it up for you.
Issue by cnvo Tuesday Mar 18, 2014 at 18:30 GMT Originally opened as https://github.com/NodeBB/NodeBB/issues/1242
If the chat can be in the task bar instead of a popup modal. The reason being is that it would save some space. To give an example, Facebook utilizes this quite well as an unobtrusive integrated application within the site. What do you guys think of this idea/enhancement?