Nuked88 / ComfyUI-N-Nodes

A suite of custom nodes for ConfyUI that includes GPT text-prompt generation, LoadVideo, SaveVideo, LoadFramesFromFolder and FrameInterpolator
MIT License
206 stars 22 forks source link

GPTSampler Error #33

Closed Aljnk closed 9 months ago

Aljnk commented 9 months ago

Describe the bug GPTSampler and GPTLoaderSimple stopped working after update.

To Reproduce Just Start

Screenshots

Screenshot_1 Screenshot_2

Desktop (please complete the following information):

Nuked88 commented 9 months ago

Please read the readme, this is happen because unfortunatly i had to change the name of the node to avoid future possible conflict.

Aljnk commented 9 months ago

I see that the names have been changed.

Screenshot_1

but I can't find new nodes

Screenshot_2
Aljnk commented 9 months ago
Screenshot_3 Screenshot_4 Screenshot_5
Nuked88 commented 9 months ago

Take a look at the confyui startup logs, maybe there are some errors

Aljnk commented 9 months ago
Traceback (most recent call last):
  File "...\Portable\ComfyUI\ComfyUI\custom_nodes\ComfyUI-N-Nodes\__init__.py", line 60, in <module>
    spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "...\Portable\ComfyUI\ComfyUI\custom_nodes\ComfyUI-N-Nodes\py\gptcpp_node.py", line 12, in <module>
    from moondream_repo.moondream.moondream import Moondream
ModuleNotFoundError: No module named 'moondream_repo.moondream.moondream'
Nuked88 commented 9 months ago

Can i have the full log please? 🤣

Aljnk commented 9 months ago

comfyui.log

Aljnk commented 9 months ago
Screenshot_1 Screenshot_2 Screenshot_3

I'm not sure, but the code: from moondream_repo.moondream.moondream import Moondream should include the file moondream.py? But I don't see the file moondream.py in the folder ...\custom_nodes\ComfyUI-N-Nodes\libs\moondream_repo\moondream\

Aljnk commented 9 months ago
  1. I delete the moondream_repo folder.

  2. Run my CMD with the command git clone https://github.com/Nuked88/moondream.git

  3. Rename the first moondream folder to moondream_repo

  4. Run my ComfyUI - everything works :)

  5. Then I delete the moondream_repo folder again (to install it from your code)

  6. Run my ComfyUI and check the moondream_repo/moondream folder - it still without moondream.py but everything works :)

Nuked88 commented 9 months ago

Hi! Yes, it worked because in the meantime I was fixing it xD. It was a problem with the checkout ID I was using on the Moondream repo I forked. Now I've put all the files on the current branch of the Moondream repository. If you delete the ComfyUI-N-Nodes folder and then do a git clone, everything should work as expected!

Aljnk commented 9 months ago

Thanks a lot!