Nuked88 / ComfyUI-N-Nodes

A suite of custom nodes for ConfyUI that includes GPT text-prompt generation, LoadVideo, SaveVideo, LoadFramesFromFolder and FrameInterpolator
MIT License
206 stars 22 forks source link

[BUG] #64

Open DaveTheDayTrader opened 5 months ago

DaveTheDayTrader commented 5 months ago

Describe the bug

Installing ComfyUI-N-Nodes causes ComfyUI startup to abort

To Reproduce Steps to reproduce the behavior:

Install ComfyUI-N-Nodes via Manager or Git - same result

Removing ComfyUI-N-Nodes from Custom Nodes fixes abort and startup completes

Expected behavior

Expecting ComfyUI to startup correctly lol

Full log

Total VRAM 7877 MB, total RAM 24031 MB pytorch version: 2.3.1+cu121 Set vram state to: NORMAL_VRAM Device: cuda:0 NVIDIA GeForce RTX 3050 : cudaMallocAsync Using pytorch cross attention [ReActor] - STATUS - Running v0.5.0-b4 in ComfyUI Torch version: 2.3.1+cu121 Total VRAM 7877 MB, total RAM 24031 MB pytorch version: 2.3.1+cu121 Set vram state to: NORMAL_VRAM Device: cuda:0 NVIDIA GeForce RTX 3050 : cudaMallocAsync Error: [Errno 39] Directory not empty: '/run/media/dave/2ac95421-f931-400f-a73d-5483df1e3826/ComfyUI/custom_nodes/ComfyUI-InstaSwap/models/facerestore_models' -> '/run/media/dave/2ac95421-f931-400f-a73d-5483df1e3826/ComfyUI/models/facerestore_models' Torch version: 2.3.1+cu121

Loading: ComfyUI-Impact-Pack (V5.18.1)

Loading: ComfyUI-Impact-Pack (Subpack: V0.6)

Loading: ComfyUI-Inspire-Pack (V0.80.4)

[Impact Pack] Wildcards loading done.

Loading: ComfyUI-Manager (V2.43)

ComfyUI Revision: 2282 [eab211bb] | Released on '2024-06-24'

[AnimateDiff] - ERROR - No models available. Please download one and put it in models folder [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json FaceDetailer: Model directory already exists FaceDetailer: Model already exists [tinyterraNodes] Loaded [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json

[rgthree] Loaded 40 exciting nodes. [rgthree] Will use rgthree's optimized recursive execution.


N-Suite Revision: ab4af9de

Current version of packaging: 24.1 Version of cpuinfo: Not found Current version of git: 3.1.43 Current version of moviepy: 1.0.3 Current version of cv2: 4.10.0 Current version of skbuild: 0.18.0 Version of typing: Not found Current version of diskcache: 5.6.3 fish: Job 1, 'python main.py' terminated by signal SIGILL (Illegal instruction)

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Operating System: Garuda Linux KDE Plasma Version: 6.1.1 KDE Frameworks Version: 6.3.0 Qt Version: 6.7.2 Kernel Version: 6.9.7-zen1-1-zen (64-bit) Graphics Platform: X11 Processors: 6 × Intel® Xeon® CPU W3670 @ 3.20GHz Memory: 23.5 GiB of RAM Graphics Processor: NVIDIA GeForce RTX 3050/PCIe/SSE2 Manufacturer: Dell Inc. Product Name: Precision WorkStation T3500

Google Chrome Version 126.0.6478.126 (Official Build) (64-bit)

Additional context Add any other context about the problem here.

hesa2020 commented 3 months ago

I am having the same issue, running on ubuntu 22.04 with python 3.10.

I went in custom_nodes/ComfyUI-N-Nodes/

I did sudo pip install -r requirements.txt

It said it installed everything correctly with no error/conflict

However when I run I still get:

N-Suite Revision: ae7cc848

Current version of packaging: 24.1 Version of cpuinfo: Not found Current version of git: 3.1.43 Current version of moviepy: 1.0.3 Current version of cv2: 4.8.0 Current version of skbuild: 0.18.0 Version of typing: Not found Current version of diskcache: 5.6.3 Illegal instruction

Edit: After debugging I found out that there is an issue with the function that retrieve version it use an attribute that isnt respected by all packages, I will upload my fix.

Then I found out the issue causing the crash is related to llama-cpp for cuda 121.

Just importing the package was crashing the application.

I grabed one from another source matching my system ( cp310 ) for cuda121 and it fixed it:

sudo python -m pip install https://github.com/abetlen/llama-cpp-python/releases/download/v0.2.89-cu121/llama_cpp_python-0.2.89-cp310-cp310-linux_x86_64.whl