search

Nukepowered / GregTech4

A port of GregTech 4 to Minecraft 1.7.10 with optimization on most processes, fixed networking and rendering.
GNU General Public License v3.0
30 stars 17 forks source link

Expanded OreDict Handler Blacklist #175

Closed DrParadox7 closed 1 year ago

DrParadox7 commented 2 years ago

Improves GT4 loading times when paired with these mods without affecting gameplay since none of them have applicable oredict.

Before:

[Client thread/DEBUG] [FML/gregtech_addon]: Bar Finished: Handling OreDict took 36.988s
 [Client thread/WARN] [GregTech/gregtech_addon]: Time spent for oredict iterating: 36.988 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]: Activating Recipe handler
 [Client thread/INFO] [GregTech/gregtech_addon]:    Smelting processor finished for 0.014 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]:    Crafting processor finished for 0.856 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]:    IC2 Recipe processor finished for 0.029 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]:    OnFinish tasks completed for 3.366 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]: Recipe handler finished for 4.267 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]: Congratulations, you have been waiting long enough. Have a Cake.

After:

[Client thread/DEBUG] [FML/gregtech_addon]: Bar Finished: Handling OreDict took 0.721s
 [Client thread/WARN] [GregTech/gregtech_addon]: Time spent for oredict iterating: 0.721 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]: Activating Recipe handler
 [Client thread/INFO] [GregTech/gregtech_addon]:    Smelting processor finished for 0.001 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]:    Crafting processor finished for 0.055 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]:    IC2 Recipe processor finished for 0.001 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]:    OnFinish tasks completed for 0.163 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]: Recipe handler finished for 0.220 seconds
 [Client thread/INFO] [GregTech/gregtech_addon]: Congratulations, you have been waiting long enough. Have a Cake.

Mostly due to item copies with just different textures like the different Bibliocraft tables made of a specific wood.

TheDarkDnKTv commented 1 year ago

I am not sure, did we discuss it in discord, but this solution is crutch. This is literaly removes any handling of ore dict. from GTs side. Since code is big and complicated, I still not fully sure what functions it has.

Fixing it require more complex solutuion, which is possibly will add a lot of bugs in game, especially with recipes of GT itself. Of course if I will start rewriting it for newer versions, I will completely rewrite this class, but since there is not much demand, I did not start it.