search

Nukesor / pueue

:stars: Manage your shell commands.
MIT License
4.67k stars 128 forks source link

issue#508 rudimentary bug fix #512

Closed Shakil582 closed 3 months ago

Shakil582 commented 3 months ago

I've never made a pull request for a github repo, this is my first open source contribution and also a rust noob.

That being said what's happening here is that we are using first as the limit but we don't remove the unused groups from the list of tasks so we are grabbing the first task which is from g1 but it won't get printed when it tries to print only the used groups.

Shakil582 commented 3 months ago

Just realized I should remove the print_single_group and rename print_all_groups and just call that since the groups are being filtered out now. Will do it later today.

Nukesor commented 3 months ago

This changes only fixes the problem, while removing another feature.

I created another MR for this fix over here, which includes tests and incorporates the filter logic into the query.. https://github.com/Nukesor/pueue/pull/513

Could you try and check whether this fixes your problem :)?