search

Nukesor / pueue

:stars: Manage your shell commands.
MIT License
4.67k stars 128 forks source link

[Bug] chrono-english breaks with latest chrono version #534

Closed Nukesor closed 1 month ago

Nukesor commented 1 month ago

Describe the bug

So, chrono released a new version where they introduced breaking changes in a minor release.

This broke some trivial things in chrono-english, however chrono-english seems to be unmaintained and the author is unresponsive. See https://github.com/stevedonovan/chrono-english/issues/29 and https://github.com/stevedonovan/chrono-english/pull/30

Due to a missing alternative, I decided to contact the maintainer of dateparser, which was open to add such functionality upstream in their crate.

I started work on this over in https://github.com/Nukesor/dateparser/tree/natural-language for https://github.com/waltzofpearls/dateparser/issues/48, but I'm getting side-tracked by work and other projects.

conradludgate commented 1 month ago

For the record, I am maintaining a fork of chrono-english. https://docs.rs/interim/latest/interim/index.html

Complete rewrite but the same tests pass and it supports time as well as chrono. Let me know if I can help at all

Nukesor commented 1 month ago

Uh nice! Your overhaul definitely looks a lot cleaner than the old chrono-english codebase :D. It was a bit of a mess, not gonna lie. I might just switch to your fork!

I was personally really interested in seeing an implementation that utilizies a proper parser library (pest in this case), but I really don't have the time to follow up on this right now :sweat_smile:

Thanks for your work! I'll take a closer look in the next few days :)

Nukesor commented 1 month ago

Thanks again @conradludgate, this saved me a lot of time and work :grin: