Nukesor / pueue

:stars: Manage your shell commands.
Apache License 2.0
5.04k stars 134 forks source link

feat: support command filter on `pueue status` #560

Closed wesleyel closed 3 months ago

wesleyel commented 4 months ago

impl #524

example:

pueue add -- ls /var

pueue status command%=ls
pueue status command=ls /var
pueue status command!=ls

I'm not sure if spaces require special handling. In the above example, the query statement seems works fine even without escaping.

Also, I would like to discuss that other than the existing OPs (eq:= neq:!= contains:%=), should we further implement the semantics of not contain?

Thanks!

Checklist

Please make sure the PR adheres to this project's standards:

github-actions[bot] commented 3 months ago

Test Results

  3 files  ± 0   19 suites  ±0   3m 8s :stopwatch: +7s 161 tests + 8  161 :white_check_mark: + 8  0 :zzz: ±0  0 :x: ±0  340 runs  +16  340 :white_check_mark: +16  0 :zzz: ±0  0 :x: ±0 

Results for commit 91d25d34. ± Comparison against base commit d6fa9a6b.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.34%. Comparing base (d6fa9a6) to head (91d25d3).

Files Patch % Lines
pueue/src/client/query/filters.rs 96.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #560 +/- ## ========================================== + Coverage 79.27% 79.34% +0.07% ========================================== Files 75 75 Lines 5664 5690 +26 ========================================== + Hits 4490 4515 +25 - Misses 1174 1175 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wesleyel commented 3 months ago

Thanks! All review fixed!

Nukesor commented 3 months ago

Perfect, looks good to me :) Thanks for the contribution :D