Closed wesleyel closed 3 months ago
3 files ± 0 19 suites ±0 3m 8s :stopwatch: +7s 161 tests + 8 161 :white_check_mark: + 8 0 :zzz: ±0 0 :x: ±0 340 runs +16 340 :white_check_mark: +16 0 :zzz: ±0 0 :x: ±0
Results for commit 91d25d34. ± Comparison against base commit d6fa9a6b.
:recycle: This comment has been updated with latest results.
Attention: Patch coverage is 96.15385%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 79.34%. Comparing base (
d6fa9a6
) to head (91d25d3
).
Files | Patch % | Lines |
---|---|---|
pueue/src/client/query/filters.rs | 96.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks! All review fixed!
Perfect, looks good to me :) Thanks for the contribution :D
impl #524
example:
I'm not sure if spaces require special handling. In the above example, the query statement seems works fine even without escaping.
Also, I would like to discuss that other than the existing OPs (eq:
=
neq:!=
contains:%=
), should we further implement the semantics ofnot contain
?Thanks!
Checklist
Please make sure the PR adheres to this project's standards:
CHANGELOG.md
.cargo clippy
andcargo fmt
. The CI will fail otherwise anyway.