search

Nuklon / Steam-Economy-Enhancer

Enhances the Steam Inventory and Steam Market.
MIT License
1.6k stars 181 forks source link

Wrong value min used (from other type of items) for relisting cards. #16

Closed omicron321 closed 7 years ago

omicron321 commented 7 years ago

Hello, Nice update for 4.0.0

I loaded http://steamcommunity.com/market/listings/753/516700-You%27ve%20Got%20Heart It is using min value of other items, it first relisted for 0,05, then tried 0,04 min value for other items, then it got relisted for 0,04...

You will notice it is highlighted in green. http://i.imgur.com/uAYJtAc.png http://i.imgur.com/xqd8cHC.png

Nuklon commented 7 years ago

Well, luckily I've that card too (4 of them in fact), but it's all 5 cents here and it's detected as a trading card.

What is happening is that you have Steam on French. Market listings do not have an identifier for the items to let me know that it's a trading card of another item, which means I have to check for the text ('trading card'), which doesn't exist in french. This same problem exists for other languages of course.

That said, I noticed there's one extra variable that I can use to check if it's a trading card or not and I've implemented this and pushed a fix out 👍

Botan626 commented 7 years ago

Hi.

SEE puts wrong min price, the settings are: lowest listing and -0.01.

But, it doesn't subtract -0.01 and puts the same lowest selling price on my item.

Nuklon commented 7 years ago

@Botan626 It respects the minimum and maximum prices you've set. If you want to change that behavior you have to lower the minimum price per item.

Botan626 commented 7 years ago

The minimum price is set way lower than the minimum selling price on market.

Nuklon commented 7 years ago

I can't reproduce that, if you have one item that always causes this you can send me a trade offer and I'll try to reproduce it with that item.

Botan626 commented 7 years ago

This happens with every item.

Here's example: the background was listed for 5,69 Rub, after I hit relist overpriced button SEE relisted it with the same price as the lowest selling one. The settings you can see in the screenshot also.

http://imgur.com/a/aZSvI

Botan626 commented 7 years ago

I keep experiencing such behaviour, with cards at present time.

Am I doing anything wrong?

Nuklon commented 7 years ago

No, the offset is applied only in inventory. Otherwise it would relist the item cheaper and cheaper again as it would then see your listing as overpriced. I don't know if this behavior can be changed, maybe with the new item information I can check if its our own listing but I don't think so.

Botan626 commented 7 years ago

"Otherwise it would relist the item cheaper and cheaper again as it would then see your listing as overpriced." --- If my item is listed with the price 0.01 lower than next selling item, how come it can be considered overpriced?

What is an overpriced item for this script then? And why it will relist overpriced items for the same actual selling price? What's the point in it?

Nuklon commented 7 years ago

Because there's no information if your item is the only item with the lowest listing price. If you would always apply the offset (a negative one) you would constantly relist it with that offset applied and thus eventually sell it for the minimum price in the options.

That said, I thought about this and it's somewhat possible to still apply the offset. I'll upload a new version in a minute or so.

Botan626 commented 7 years ago

"Because there's no information if your item is the only item with the lowest listing price." --- there is no way to determine the quantity of items selling at the lowest price?

Anyway, the new version works fine, the items are marked as underpriced now, but it's no big deal.

Thank you.

Nuklon commented 7 years ago

Well, there sort of is, but that data is not reliable. Otherwise I'd have to load all pages on Steam again and then you'd have a way slower check as it's rather rate limited.

Underpriced items haven't changed, that's still the same.