Null-MC / Shrimple

A simple Minecraft Java shader that attempts to maintain the vanilla aesthetic while adding optional shadows & colored lighting.
Other
122 stars 6 forks source link

Volumetric lighting are causing dithering patterns everywhere #32

Open TheStarFallen opened 1 year ago

TheStarFallen commented 1 year ago

fog in distance is showing everything in this pattern when standing in volumetric lights iris version: iris version 1.6.4 mc version: 1.19.4 newest drivers 2023-07-13_11 46 08

christopher317 commented 1 year ago

iv had this same issue before, i find that increasing the quality helps at the cost of a lot performance. i think a easy fix for this would be to add a option to blur the fog ( like with shadows and block lighting ) to reduce the noise.

until null sees this and fixes this tho there's no easy fix.

null511 commented 1 year ago

volumetric fog already has a post-blurring option; it just doesn't work as well on a 3D volume as it does 2D surface shadows.

And yes, then only fix is to increase quality so it traces smaller steps. What you're seeing is the dithering applied to keep the low sample count from showing "ghost copies" of the actual scene.