search

Null-MC / Shrimple

A simple Minecraft Java shader that attempts to maintain the vanilla aesthetic while adding optional shadows & colored lighting.
Other
124 stars 6 forks source link

1.21 blocks trace rendering support + Integrated PBR 1.21 blocks support #74

Open ShrikerChestTrees opened 6 months ago

ShrikerChestTrees commented 6 months ago

When you posted your commit that there is support for 1.21 blocks, I checked and everything works, but not the way it should, here are screenshots for examples: 2024-03-25_09 56 28 2024-03-25_09 57 23 So fix the block rendering from 1.21 and Integrated PBR for 1.21 blocks. Thank you in advance.

null511 commented 6 months ago

ah, I'm pretty sure I missed copper doors entirely, forgot they were added. thanks!

null511 commented 6 months ago

I fixed copper doors & trapdoors in the latest commit, but what's the issue in that second pic? it looks like a button, but afaik I added them all

ShrikerChestTrees commented 6 months ago

I fixed copper doors & trapdoors in the latest commit, but what's the issue in that second pic? it looks like a button, but afaik I added them all

It's not the button, it's the problem with the integrated PBR. What is glowing is a glowing copper block, which is not even reflected like other new blocks from 1.21.

null511 commented 6 months ago

Can't do anything about the copper glowing, I am not going to be adding per-pixel IPBR like Emin did with Comp. For that you'll need a PBR RP.

I can fix the reflections though...

ShrikerChestTrees commented 6 months ago

Can't do anything about the copper glowing, I am not going to be adding per-pixel IPBR like Emin did with Comp. For that you'll need a PBR RP.

I can fix the reflections though...

OK. Thx!